feat: add confidence indicator to AI field marker - #12436
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The indicator was appended to the field, so it landed after a helper the field already had. Removing it also made the helper controller restore and re-append its default node, moving the helper to the end and flipping the order on the next mark. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The marker emulated the field's helper text section styles, which missed theme rules keyed on the attribute. In Lumo the indicator lost the spacing below the input, and the helper-above-field theme rendered it below the field instead of above it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The indicator is added to the field's light DOM, next to the application's own children, where a plain `confidence` or `low` class name can collide. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The base styles and themes key on the indicator's class names; the field attribute was a second styling contract nothing used. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
There was a problem hiding this comment.
Reviewed the changes — left 3 comments.
| Finding | |
|---|---|
The has-helper re-assert observer's callback closes over a stale field, so a marker reused on a second field writes has-helper to the wrong element. |
|
| 🧹 | #hasFieldHelper re-implements the field's own helper-content detection, which will drift from the field's rule. |
| 👀 | The marker drives the field's private has-helper attribute from outside and installs an observer to fight the field's own recomputation. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jouni
reviewed
Aug 17, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Member
|
LGTM as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
confidenceproperty (low,medium,high) and renders an indicator with a pie icon and level text in the field's helper text section, ahead of the field's own helper.workingis set — including for screen readers — since it describes a value that is about to be replaced.i18n.confidence, and the indicator colors can be themed through custom CSS properties, mapped to the semantic palettes in Lumo and Aura.🤖 Generated with Claude Code