refactor: add hasNodeContent helper for checking node content - #12437
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
web-padawan
approved these changes
Aug 14, 2026
web-padawan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SlotChildObserveControllerdecides whether a slotted node has content (an element with children, a defined custom element that may render in its shadow root, or non-empty text) with a private check that other code cannot reuse. The AI field marker in feat: add confidence indicator to AI field marker #12436 needs the same rule to judge a field's helper content, and re-implementing it there risks the two copies drifting apart, as noted in the review comment: feat: add confidence indicator to AI field marker #12436 (comment)hasNodeContent()from component-basedom-utils, used by the controller and covered with unit tests, so the marker (and any future caller) can share the single definition.Related to #12436
🤖 Generated with Claude Code