-
Notifications
You must be signed in to change notification settings - Fork 101
feat: add confidence indicator to AI field marker #12436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4b23438
feat: add confidence indicator to AI field marker
tomivirkki c9e1f38
feat: inset confidence indicator pie from its ring
tomivirkki bfca6d6
refactor: use theme color tokens for confidence indicator
tomivirkki 27ef6a0
fix: render confidence indicator before field helper content
tomivirkki ae29324
chore: drop slot controller fix from branch
tomivirkki 2749c8e
fix: set has-helper on field while confidence indicator is shown
tomivirkki f6da824
refactor: prefix confidence indicator class names
tomivirkki 0dfcd59
fix: keep has-helper for a helper that renders in shadow DOM
tomivirkki 6f7ddf3
fix: exclude hidden confidence indicator from field description
tomivirkki 9007d10
refactor: drop ai-confidence attribute in favor of level class names
tomivirkki ac8f206
refactor: drop redundant guard when releasing has-helper
tomivirkki 90f07dd
test: cover mutation gaps in ai-field-marker confidence
tomivirkki 72ee977
fix: re-assert has-helper on the field the marker was moved to
tomivirkki 34b9f77
Merge remote-tracking branch 'origin/main' into feat/ai-field-marker-…
tomivirkki 3baf84f
refactor: use shared node content check for field helper
tomivirkki 7044ba8
docs: remove internal mask position property from styling tables
tomivirkki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| :has(> vaadin-ai-field-marker) { | ||
| --vaadin-ai-field-marker-confidence-low-color: var(--aura-red-text); | ||
| --vaadin-ai-field-marker-confidence-medium-color: var(--aura-yellow-text); | ||
| --vaadin-ai-field-marker-confidence-high-color: var(--aura-green-text); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.