-
Notifications
You must be signed in to change notification settings - Fork 3
L 8 question texts can be too long restored #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lschulen
wants to merge
38
commits into
v3.4.0
Choose a base branch
from
L_8-question-texts-can-be-too-long-restored
base: v3.4.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
ca13504
Backend Prüfung klappt, aber Html Tags etc werden noch mitgezählt
lschulen 2fb3e8f
Backend Prüfung klappt, aber Html Tags etc werden noch mitgezählt
lschulen afcbb64
Backend Prüfung klappt, aber Html Tags etc werden noch mitgezählt
lschulen b4c9fe5
aktueller Stand 26-07-15
lschulen aea6bcc
Merge remote-tracking branch 'origin/L_8-question-texts-can-be-too-lo…
lschulen 8acfdbc
errormessages
lschulen 2a54c74
Added a helper function to remove all HTML tags when counting the cha…
lschulen ba12df4
Added Counting functionality for the amount of characters in Descript…
lschulen 122905c
corrected the calculation of the number of characters
lschulen 086b742
Merge branch 'v3.4.0' into L_8-question-texts-can-be-too-long-restored
ywarnecke 07ca4e7
Refactor visible text extraction into HtmlUtilities
lschulen 5a6f8cc
Add live question text length validation
lschulen b182d43
Made live WYSIWYG length validation reusable and applied it in questi…
lschulen 6d9927f
Added message keys and adjusted the frontend
lschulen 30db67d
adjusted the backend as well
lschulen 3e83d87
implemented frontend check for bundles and enures that info disappear…
lschulen 0fc62f2
implemented backend check for bundles
lschulen d69f783
Added new message keys if welcometext or final text is too long
lschulen 3fb2314
Added backend check if any welcome text in bundle is too long
lschulen e651dfa
Added backend check if any final text in bundle is too long
lschulen dba9c6e
Added frontend check if any welcome or final text in bundle is too long
lschulen fe0eed7
Added backend check if any welcome or final text in questionnaire is …
lschulen 350d406
Added frontend check if any welcome or final text in questionnaire is…
lschulen 5d52c45
correced a variable name
lschulen df160aa
Added frontend check if description text in clinic is too long
lschulen 4faae27
Added backend check if description text in clinic is too long
lschulen 8fdda9b
Added backend check if description text in clinic is empty
lschulen 065e298
Optimized isEmpty check for description in bundle
lschulen 506a5cb
Optimized isEmpty check for description in bundle
lschulen 7ba9138
Added backend check if message in invitation is too long. added those…
lschulen ab9467e
Added frontend check if message in invitation is too long. needed a d…
lschulen 13ee45c
comment
lschulen 89e9667
deleted sysout
lschulen 372caee
Show only one error message for completely empty text fields in Bundl…
lschulen 57e16f1
Fixed JUnit errors
lschulen dee334f
Started JUnit Tests in Bundle. Still producing error
lschulen 7a5ad0f
Fix: Removed outdated duplicates in src/test/resources/message
lschulen 500a677
Added tests for welcome and final text length validation in BundleDTO…
lschulen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1346,6 +1346,20 @@ | |
| $(this).attr("disabled", true); | ||
| } | ||
| }); | ||
|
|
||
| // Überwachung der WYSIWYG-Editoren auf maximale Länge | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please adjust this solution:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also please dont use german comments in the code base |
||
| $(document).on('keydown', '.note-editable', function(e) { | ||
| var currentLength = $(this).text().length; | ||
| if (currentLength >= 1500) { | ||
| // Verhindere die Eingabe, wenn 1500 Zeichen erreicht sind | ||
| // (Ausnahme: Backspace/Delete Taste erlauben) | ||
| console.log("Textlaenge ueberschritten") | ||
| if (e.keyCode !== 8 && e.keyCode !== 46) { | ||
| e.preventDefault(); | ||
| alert("Maximale Länge von 1500 Zeichen erreicht!"); | ||
| } | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| /*[- Reduce the size of multiple choice answers to 98% for the move buttons -]*/ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use the same utility function twice, please see if it can be moved to an existing Helper class to reduce code duplicates. Otherwise you could also create a new HTMLHelper.