L 8 question texts can be too long restored

src/main/java/de/imi/mopat/helper/controller/HtmlUtilities.java

@@ -21,4 +21,34 @@ public static String getStringWithoutHtml(final String htmlString) {
         }
         return htmlString.replaceAll("\\<[^>]*>", "");
     }
+
+    /*
+     * Converts HTML content to countable visible text for validation.
+     * Unlike getStringWithoutHtml(...), this also preserves visible line breaks
+     * from tags like <br>, </p> or </div> and decodes common HTML entities
+     * such as &nbsp.
+     */
+    public static String getVisibleText(String html) {
+        if (html == null || html.isEmpty()) {
+            return "";
+        }
+
+        String text = html
+                .replace("\r\n", "\n")
+                .replace("\r", "\n");
+
+        text = text.replaceAll("(?i)<br\\s*/?>", "\n");
+        text = text.replaceAll("(?i)</(?:div|p|li|h[1-6])\\s*>", "\n");
+        text = text.replaceAll("(?s)<[^>]+>", "");
+
+        text = text.replace("&nbsp;", " ");
+        text = text.replace("&amp;", "&");
+        text = text.replace("&lt;", "<");
+        text = text.replace("&gt;", ">");
+        text = text.replace("&quot;", "\"");
+        text = text.replace("&#39;", "'");
+
+        return text.replaceAll("\n{3,}", "\n\n").trim();
+    }
+
 }

src/main/java/de/imi/mopat/validator/BundleDTOValidator.java

@@ -1,6 +1,7 @@
 package de.imi.mopat.validator;
 
 import de.imi.mopat.dao.BundleDao;
+import de.imi.mopat.helper.controller.HtmlUtilities;
 import de.imi.mopat.helper.controller.HtmlUtils;
 import de.imi.mopat.model.Bundle;
 import de.imi.mopat.model.dto.BundleDTO;
@@ -21,6 +22,11 @@
 @Component
 public class BundleDTOValidator implements Validator {
 
+    // Needs to be public because it's used in BundleDto
+    public static final int MAX_DESCRIPTION_TEXT_LENGTH = 2_000;
+    public static final int MAX_WELCOME_TEXT_LENGTH = 5_000;
+    public static final int MAX_FINAL_TEXT_LENGTH = 5_000;
+
     @Autowired
     private MessageSource messageSource;
 
@@ -56,12 +62,17 @@ public void validate(final Object o, final Errors errors) {
                     LocaleContextHolder.getLocale()));
         }
 
-        String bundleDescription = HtmlUtils.removeHtmlTags(bundleDTO.getDescription());
-
-        if (bundleDescription != null && bundleDescription.isEmpty()) {
+        // Check if description text is too long or empty
+        int visibleDescpriptionLength = HtmlUtilities.getVisibleText(bundleDTO.getDescription()).length();
+        if(visibleDescpriptionLength > MAX_DESCRIPTION_TEXT_LENGTH){
+            errors.rejectValue("description",
+                    MoPatValidator.ERRORCODE_ERRORMESSAGE,
+                    messageSource.getMessage("questionnaire.error.descriptionTooLong",
+                            new Object[]{visibleDescpriptionLength, MAX_DESCRIPTION_TEXT_LENGTH}, LocaleContextHolder.getLocale()));
+        } else if (bundleDTO.getDescription() != null && !bundleDTO.getDescription().isEmpty() && visibleDescpriptionLength == 0) {
             errors.rejectValue("description", "errormessage",
-                messageSource.getMessage("bundle.description.notNull", new Object[]{},
-                    LocaleContextHolder.getLocale()));
+                    messageSource.getMessage("bundle.description.notNull", new Object[]{},
+                            LocaleContextHolder.getLocale()));
         }
 
         // Check if at least the first questionnaire is enabled in this bundle
@@ -104,6 +115,17 @@ public void validate(final Object o, final Errors errors) {
                         messageSource.getMessage("bundle.validator" + ".welcomeText" + ".notNull",
                             new Object[]{}, LocaleContextHolder.getLocale()));
                 }
+                // Check if current welcome text is too long
+                else {
+                    int visibleWelcomeTextLength = HtmlUtilities.getVisibleText(entry.getValue()).length();
+                    if (visibleWelcomeTextLength > MAX_WELCOME_TEXT_LENGTH){
+                        errors.rejectValue("localizedWelcomeText[" + entry.getKey() + "]",
+                                MoPatValidator.ERRORCODE_ERRORMESSAGE,
+                                messageSource.getMessage("questionnaire.error.welcomeTextTooLong",
+                                        new Object[]{visibleWelcomeTextLength, MAX_WELCOME_TEXT_LENGTH}, LocaleContextHolder.getLocale()));
+
+                    }
+                }
             }
         }
 
@@ -130,6 +152,17 @@ public void validate(final Object o, final Errors errors) {
                         messageSource.getMessage("bundle.validator" + ".finalText" + ".notNull",
                             new Object[]{}, LocaleContextHolder.getLocale()));
                 }
+                // Check if current final text is too long
+                else {
+                    int visibleFinalTextLength = HtmlUtilities.getVisibleText(entry.getValue()).length();
+                    if (visibleFinalTextLength > MAX_FINAL_TEXT_LENGTH){
+                        errors.rejectValue("localizedFinalText[" + entry.getKey() + "]",
+                                MoPatValidator.ERRORCODE_ERRORMESSAGE,
+                                messageSource.getMessage("questionnaire.error.finalTextTooLong",
+                                        new Object[]{visibleFinalTextLength, MAX_FINAL_TEXT_LENGTH}, LocaleContextHolder.getLocale()));
+
+                    }
+                }
             }
         }
     }

src/main/java/de/imi/mopat/validator/ClinicDTOValidator.java

@@ -1,6 +1,7 @@
 package de.imi.mopat.validator;
 
 import de.imi.mopat.dao.ClinicDao;
+import de.imi.mopat.helper.controller.HtmlUtilities;
 import de.imi.mopat.model.dto.ClinicConfigurationMappingDTO;
 import de.imi.mopat.model.dto.ClinicDTO;
 
@@ -18,6 +19,8 @@
 @Component
 public class ClinicDTOValidator implements Validator {
 
+    private static final int MAX_DESCRIPTION_TEXT_LENGTH = 2_000;
+
     @Autowired
     private MessageSource messageSource;
     @Autowired
@@ -53,6 +56,22 @@ public void validate(final Object o, final Errors errors) {
                 messageSource.getMessage("clinic.error.nameInUse", new Object[]{},
                     LocaleContextHolder.getLocale()));
         }
+
+        // Check if description text is too long or empty
+        int visibleDescpriptionLength = HtmlUtilities.getVisibleText(clinicDTO.getDescription()).length();
+        if(visibleDescpriptionLength > MAX_DESCRIPTION_TEXT_LENGTH){
+            errors.rejectValue("description",
+                    MoPatValidator.ERRORCODE_ERRORMESSAGE,
+                    messageSource.getMessage("questionnaire.error.descriptionTooLong",
+                            new Object[]{visibleDescpriptionLength, MAX_DESCRIPTION_TEXT_LENGTH}, LocaleContextHolder.getLocale()));
+        } else if (visibleDescpriptionLength == 0) {
+            errors.rejectValue("description", "errormessage",
+                    messageSource.getMessage("clinic.description.notNull", new Object[]{},
+                            LocaleContextHolder.getLocale()));
+        }
+
+
+
         if (!checkIfAnyOnePatientRetrieverIsEnabled(clinicDTO)) {
             errors.rejectValue("clinicConfigurationMappingDTOS[0].value", MoPatValidator.ERRORCODE_ERRORMESSAGE,
                 messageSource.getMessage("clinic.error.noConfiguration",

src/main/java/de/imi/mopat/validator/InvitationDTOValidator.java

@@ -1,5 +1,6 @@
 package de.imi.mopat.validator;
 
+import de.imi.mopat.helper.controller.HtmlUtilities;
 import de.imi.mopat.model.dto.InvitationDTO;
 import de.imi.mopat.model.dto.InvitationUserDTO;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -15,6 +16,8 @@
 @Component
 public class InvitationDTOValidator implements Validator {
 
+    private static final int MAX_PERSONAL_TEXT_LENGTH = 2000;
+
     @Autowired
     private MessageSource messageSource;
 
@@ -65,5 +68,15 @@ public void validate(final Object o, final Errors errors) {
             }
         }
 
+        // Checks if message is too long (message is named personalText in DTO)
+        int personalTextLength = HtmlUtilities.getVisibleText(invitationDTO.getPersonalText()).length();
+        if (personalTextLength > MAX_PERSONAL_TEXT_LENGTH){
+            errors.rejectValue("personalText",
+                    MoPatValidator.ERRORCODE_ERRORMESSAGE,
+                    messageSource.getMessage("invitation.message.tooLong",
+                            new Object[]{personalTextLength, MAX_PERSONAL_TEXT_LENGTH},
+                            LocaleContextHolder.getLocale()));
+        }
+
     }
 }

src/main/java/de/imi/mopat/validator/QuestionDTOValidator.java

@@ -3,11 +3,11 @@
 import de.imi.mopat.model.enumeration.QuestionType;
 import de.imi.mopat.model.dto.AnswerDTO;
 import de.imi.mopat.model.dto.QuestionDTO;
+import de.imi.mopat.helper.controller.HtmlUtilities;
 
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
-import java.util.regex.Pattern;
 
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.MessageSource;
@@ -25,6 +25,7 @@ public class QuestionDTOValidator implements Validator {
 
     private static final String MIN_NUMBER_ANSWERS = "minNumberAnswers";
     private static final String MAX_NUMBER_ANSWERS = "maxNumberAnswers";
+    private static final int MAX_QUESTION_TEXT_LENGTH = 2_000;
     @Autowired
     private SelectAnswerDTOValidator selectAnswerDTOValidator;
     @Autowired
@@ -56,10 +57,10 @@ public void validate(final Object target, final Errors errors) {
         // [bt] now it's my time to validate the more complex stuff
         QuestionDTO questionDTO = (QuestionDTO) target;
 
-        // [sw] Check if any added language contains an empty questionText
+        // [sw] Check if any added language contains an empty or too long questionText
         for (Map.Entry<String, String> entry : questionDTO.getLocalizedQuestionText().entrySet()) {
-            if (entry.getValue() == null || entry.getValue().trim().isEmpty() || Pattern.matches(
-                "<p>(<p>|</p>|\\s|&nbsp;|<br>)+<\\/p>", entry.getValue())) {
+            String visibleQuestionText = HtmlUtilities.getVisibleText(entry.getValue());
+            if (visibleQuestionText.isEmpty()) {
                 questionDTO.getLocalizedQuestionText().put(entry.getKey(), "");
                 if (questionDTO.getQuestionType() == QuestionType.INFO_TEXT) {
                     errors.rejectValue("localizedQuestionText[" + entry.getKey() + "]",
@@ -72,6 +73,11 @@ public void validate(final Object target, final Errors errors) {
                         messageSource.getMessage("question.error" + ".questionTextIsNull",
                             new Object[]{}, LocaleContextHolder.getLocale()));
                 }
+            } else if(visibleQuestionText.length() > MAX_QUESTION_TEXT_LENGTH){
+                errors.rejectValue("localizedQuestionText[" + entry.getKey() + "]",
+                        MoPatValidator.ERRORCODE_ERRORMESSAGE,
+                        messageSource.getMessage("question.error.questionTextTooLong",
+                                new Object[]{visibleQuestionText.length(),MAX_QUESTION_TEXT_LENGTH}, LocaleContextHolder.getLocale()));
             }
         }
 

src/main/java/de/imi/mopat/validator/QuestionnaireDTOValidator.java

@@ -3,6 +3,7 @@
 import de.imi.mopat.dao.QuestionnaireDao;
 import de.imi.mopat.model.Questionnaire;
 import de.imi.mopat.model.dto.QuestionnaireDTO;
+import de.imi.mopat.helper.controller.HtmlUtilities;
 
 import java.util.Map;
 import java.util.regex.Pattern;
@@ -20,12 +21,18 @@
 @Component
 public class QuestionnaireDTOValidator implements Validator {
 
+    private static final int MAX_DESCRIPTION_TEXT_LENGTH = 2_000;
+    private static final int MAX_WELCOME_TEXT_LENGTH = 5_000;
+    private static final int MAX_FINAL_TEXT_LENGTH = 5_000;
+
+
     @Autowired
     private MessageSource messageSource;
 
     @Autowired
     private QuestionnaireDao questionnaireDao;
 
+
     @Override
     public boolean supports(final Class<?> type) {
         return QuestionnaireDTO.class.isAssignableFrom(type);
@@ -56,6 +63,19 @@ public void validate(final Object o, final Errors errors) {
                     LocaleContextHolder.getLocale()));
         }
 
+        // Check if the description text is too long or empty
+        int visibleDescpriptionLength = HtmlUtilities.getVisibleText(questionnaireDTO.getDescription()).length();
+        if(visibleDescpriptionLength > MAX_DESCRIPTION_TEXT_LENGTH){
+            errors.rejectValue("description",
+                    MoPatValidator.ERRORCODE_ERRORMESSAGE,
+                    messageSource.getMessage("questionnaire.error.descriptionTooLong",
+                            new Object[]{visibleDescpriptionLength, MAX_DESCRIPTION_TEXT_LENGTH}, LocaleContextHolder.getLocale()));
+        } else if (questionnaireDTO.getDescription() != null && !questionnaireDTO.getDescription().isEmpty() && visibleDescpriptionLength == 0) {
+            errors.rejectValue("description", "errormessage",
+                    messageSource.getMessage("questionnaire.description.notNull", new Object[]{},
+                            LocaleContextHolder.getLocale()));
+        }
+
         // [sw] Check if any added language contains an empty questionText
         for (Map.Entry<String, String> entry : questionnaireDTO.getLocalizedDisplayName()
             .entrySet()) {
@@ -93,6 +113,17 @@ public void validate(final Object o, final Errors errors) {
                             "questionnaire.validator" + ".welcomeText" + ".notNull", new Object[]{},
                             LocaleContextHolder.getLocale()));
                 }
+                // Check if current welcome text is too long
+                else {
+                    int visibleWelcomeTextLength = HtmlUtilities.getVisibleText(entry.getValue()).length();
+                    if (visibleWelcomeTextLength > MAX_WELCOME_TEXT_LENGTH){
+                        errors.rejectValue("localizedWelcomeText[" + entry.getKey() + "]",
+                                MoPatValidator.ERRORCODE_ERRORMESSAGE,
+                                messageSource.getMessage("questionnaire.error.welcomeTextTooLong",
+                                        new Object[]{visibleWelcomeTextLength, MAX_WELCOME_TEXT_LENGTH}, LocaleContextHolder.getLocale()));
+
+                    }
+                }
             }
         }
 
@@ -121,6 +152,17 @@ public void validate(final Object o, final Errors errors) {
                             "questionnaire.validator" + ".finalText" + ".notNull", new Object[]{},
                             LocaleContextHolder.getLocale()));
                 }
+                // Check if current final text is too long
+                else {
+                    int visibleFinalTextLength = HtmlUtilities.getVisibleText(entry.getValue()).length();
+                    if (visibleFinalTextLength > MAX_FINAL_TEXT_LENGTH){
+                        errors.rejectValue("localizedFinalText[" + entry.getKey() + "]",
+                                MoPatValidator.ERRORCODE_ERRORMESSAGE,
+                                messageSource.getMessage("questionnaire.error.finalTextTooLong",
+                                        new Object[]{visibleFinalTextLength, MAX_FINAL_TEXT_LENGTH}, LocaleContextHolder.getLocale()));
+
+                    }
+                }
             }
         }
     }

src/main/resources/message/messages.properties

@@ -625,6 +625,7 @@ invitation.label.fileInfo=The personal data, first name, surname and e-mail addr
 invitation.label.firstname=First name
 invitation.label.lastname=Last name
 invitation.label.user=User
+invitation.message.tooLong=The message contains {0} characters and exceeds the maximum of {1} characters.
 layout.button.back=Go Back
 layout.button.close=Cancel and exit
 layout.footer.copyright=2026 Institute of Medical Informatics,<br> University of M\u00fcnster
@@ -734,6 +735,7 @@ question.error.noValidScoreMinMax=It is not possible to give exactly one answer.
 question.error.noValidScoreQuestionType=A question type has been selected that does not support score calculation. If you save the question, all scores that contain this question will be deleted. Do you really want to save the question?
 question.error.notModifiable=This question is not editable due to already existing responses from surveys
 question.error.questionTextIsNull=The localized question text is required
+question.error.questionTextTooLong=The question text contains {0} characters and exceeds the maximum of {1} characters.
 question.error.sliderDifferenceMaxMinNotDivisibleByStepsize=The difference between max and min values is not divisible without remainder by the step size
 question.error.sliderStepsizeLessOrEqualToZero=The stepsize should not be less or equal to 0
 question.heading.editQuestion=Edit question
@@ -815,11 +817,14 @@ questionnaire.button.showExportTemplates=Edit export templates
 questionnaire.displayName.notNull=The localized display name is required
 questionnaire.error.deleteQuestionnaireNotPossible=Questionnaire {0} cannot be deleted because the questionnaire is already answered in a survey.
 questionnaire.error.deleteQuestionnairePossible=The questionnaire {0} was deleted.
+questionnaire.error.descriptionTooLong=The description contains {0} characters and exceeds the maximum of {1} characters.
 questionnaire.error.editLastCondition=This is the last question of this questionnaire. Thus, conditions for this question cannot be specified.
+questionnaire.error.finalTextTooLong=The final text contains {0} characters and exceeds the maximum of {1} characters.
 questionnaire.error.import=An error occured during the import of a questionnaire file: {0}
 questionnaire.error.nameContainsSpecialCharacters=The name you entered contains invalid characters. Only letters, numbers and the special characters !?+-_.:()[] are allowed.
 questionnaire.error.nameInUse=The chosen name is already in use. Please choose a different one.
 questionnaire.error.nameIsEmpty=The name shouldn't only consist of space characters.
+questionnaire.error.welcomeTextTooLong=The welcome text contains {0} characters and exceeds the maximum of {1} characters.
 questionnaire.heading.editQuestionnaire=Edit questionnaire
 questionnaire.heading.title=Questionnaires
 questionnaire.import.button.import=Upload &amp; Import
@@ -1049,6 +1054,7 @@ survey.title.fontSize=Select a font size
 survey.title.searchCaseNumber=Search for case number
 survey.title.selectBundle=Select bundle
 survey.title.selectClinic=Select clinic
+textLength.error.exceeded=Character limit exceeded ({0} / {1})
 typeMismatch.answers.maxValue=The maximum's value of the slider must be an integer value
 typeMismatch.answers.minValue=The minimum's value of the slider must be an integer value
 typeMismatch.answers.value=The score must be an integer value