L 8 question texts can be too long restored - #322
Open
lschulen wants to merge 36 commits into
Open
Conversation
…ng-restored' into L_8-question-texts-can-be-too-long-restored
…racters in a text
…ion of Questionares
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
ywarnecke
requested changes
Aug 18, 2026
| } | ||
| }); | ||
|
|
||
| // Überwachung der WYSIWYG-Editoren auf maximale Länge |
Member
There was a problem hiding this comment.
Please adjust this solution:
- It should show a red label above the textarea instead of an alert.
- Remove the console print
- Adjust the message to be language dependent. You can replace Javascript variables with Thymeleaf. You can see how starting from line 1251
Member
There was a problem hiding this comment.
Also please dont use german comments in the code base
| } | ||
|
|
||
| // A utility function to remove all HTML tags when counting the characters in a text | ||
| public static String getVisibleText(String html) { |
Member
There was a problem hiding this comment.
If you use the same utility function twice, please see if it can be moved to an existing Helper class to reduce code duplicates. Otherwise you could also create a new HTMLHelper.
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Add reusable HtmlUtilities.getVisibleText helper for client-side validation. Show a localized inline error label when the visible question text exceeds the maximum length. Remove the previous alert-based validation and console output. TODO: Reuse this validation in questionnaire/edit and bundle/edit.
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
…s when going back under limit
Test Results🧪 Unit Test Results🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
… message keys as well
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
…ifferent handling bc inivtation\edit doesn't use wysiwyg
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
…eDTOValidator, QuestionnaireDTOValidator and QuestionDTOValidator.
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
Test Results🧪 Unit Test Results
🌐 Selenium Test ResultsRunning Test:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.