Conversation
This was referenced Sep 9, 2026
anwesham-lab
approved these changes
Sep 14, 2026
praba2210
reviewed
Sep 14, 2026
| assertThat(DSQLTable.class.getSuperclass()).isEqualTo(PostgreSQLTable.class); | ||
| assertThat(DSQLTable.class.getDeclaredMethods()) | ||
| .extracting(Method::getName) | ||
| .doesNotContain("doLock"); |
There was a problem hiding this comment.
The doesNotContain("doLock") assert does not verify anything. Same for the superclass check, which the compiler already enforces. Consider dropping the test, or asserting what SQL lock() actually issues against a mocked JdbcTemplate.
Author
There was a problem hiding this comment.
Removed the reflection test as suggested. The production change now relies on the inherited PostgreSQLTable implementation without a structural test. Re-ran sh ../mvnw test: 70 tests passed, 3 live integration tests skipped.
Author
There was a problem hiding this comment.
sorry for the ai response, did not tell it to do that. I had the test removed since I don't think mocking a jdbctemplate for this is worth anything
anwesham-lab
pushed a commit
to awslabs/aurora-dsql-orms
that referenced
this pull request
Sep 14, 2026
## Summary Update Aurora DSQL ORM adapters and guidance for the GA SELECT FOR UPDATE behavior. Part of a coordinated rollout; sibling PR links will be added after all PRs are opened. ## Changes - Update Hibernate guidance and add coverage for non-key predicates with an inner join. - Preserve Hibernate's outer-join limitation. - Enable Tortoise `select_for_update()` while disabling unsupported `FOR NO KEY UPDATE`. - Add Tortoise coverage for non-key filters and both `update_or_create()` paths. - Document commit-time OCC behavior, SQLSTATE 40001 retries, and 10 MiB locked-primary-key accounting. - Document Tortoise's outer-join query-builder limitation for joined locking queries. ## Validation - Hibernate: `./gradlew test` passed. - Tortoise: Ruff format/lint passed; 124 unit tests and 6 subtests passed. - Live Aurora DSQL integration tests were not run locally. ## Related rollout PRs - Canonical agent guidance: awslabs/agent-plugins#271 - Kiro Power mirror: awslabs/mcp#4607 - Flyway compatibility cleanup: flyway/flyway-community-db-support#149 - ORM adapters: #626 - Samples: aws-samples/aurora-dsql-samples#1821
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the obsolete Aurora DSQL
DSQLTable.doLock()no-op now thatSELECT ... FOR UPDATEno longer requires equality predicates on every primary-key column. This is compatibility cleanup only;DSQLConnection.lock()and Flyway migration-wide coordination behavior are unchanged.Part of a coordinated Aurora DSQL SELECT FOR UPDATE rollout. Sibling PR links will be added after all PRs are opened.
Changes
Validation
sh ../mvnw test: 70 tests passed, 3 live integration tests skipped.Related rollout PRs