Skip to content

docs(aurora-dsql): update SELECT FOR UPDATE Kiro guidance - #4607

Merged
anwesham-lab merged 2 commits into
awslabs:mainfrom
mchenjh:fix/dsql-select-for-update
Sep 14, 2026
Merged

anwesham-lab merged 2 commits into
awslabs:mainfrom
mchenjh:fix/dsql-select-for-update

Conversation

@mchenjh

@mchenjh mchenjh commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Mirror the canonical Aurora DSQL SELECT FOR UPDATE guidance in the Kiro Power. This is part of a coordinated rollout; sibling PR links will be added after all PRs are opened.

Changes

  • Remove obsolete all-primary-key equality and single-table restrictions.
  • Document commit-time OCC behavior, supported lock clauses, SQLSTATE 40001 retries, and 10 MiB locked-primary-key accounting.
  • Correct framework guidance and routing for locking questions.
  • Add a changelog entry.

User experience

Kiro now recommends supported SELECT FOR UPDATE query shapes and whole-transaction retry behavior without carrying the pre-GA restrictions.

Checklist

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? N

RFC issue number: N/A

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Related rollout PRs

@mchenjh

mchenjh commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Review pass 1

Reviewed the Kiro steering rollout finalized in commit 889603e with 16+ independent roles. Findings around Rails transaction boundaries, joined-query wording, lock-clause support, SQLSTATE 40001 retries, and 10 MiB locked-primary-key accounting were addressed in the canonical guidance and mirrored here.

Validation: the Kiro steering file is byte-identical to the canonical agent-plugin guidance.

@mchenjh

mchenjh commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Review pass 2

A fresh 16-reviewer convergence pass was completed, followed by direct current-file verification. No unresolved behavioral or CI-blocking findings remain in commit 889603e.

Final validation: canonical and Kiro steering files are byte-identical, the agent-side deterministic suite passed 60 tests, and the MCP diff passes git diff --check. The full model eval infrastructure timed out before producing a subject response; details are recorded on the canonical agent-plugin PR.

@mchenjh mchenjh changed the title Update Aurora DSQL SELECT FOR UPDATE Kiro guidance docs(aurora-dsql): update SELECT FOR UPDATE Kiro guidance Sep 9, 2026
anwesham-lab
anwesham-lab previously approved these changes Sep 14, 2026
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.33%. Comparing base (a05c9bf) to head (4c1d1a3).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4607   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files        1059     1059           
  Lines       90366    90366           
  Branches    14614    14614           
=======================================
  Hits        84343    84343           
  Misses       3618     3618           
  Partials     2405     2405           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anwesham-lab
anwesham-lab added this pull request to the merge queue Sep 14, 2026
Merged via the queue into awslabs:main with commit 733ff48 Sep 14, 2026
137 checks passed
@github-project-automation github-project-automation Bot moved this from To triage to Done in awslabs/mcp Project Sep 14, 2026
anwesham-lab pushed a commit to awslabs/aurora-dsql-orms that referenced this pull request Sep 14, 2026
## Summary

Update Aurora DSQL ORM adapters and guidance for the GA SELECT FOR
UPDATE behavior. Part of a coordinated rollout; sibling PR links will be
added after all PRs are opened.

## Changes

- Update Hibernate guidance and add coverage for non-key predicates with
an inner join.
- Preserve Hibernate's outer-join limitation.
- Enable Tortoise `select_for_update()` while disabling unsupported `FOR
NO KEY UPDATE`.
- Add Tortoise coverage for non-key filters and both
`update_or_create()` paths.
- Document commit-time OCC behavior, SQLSTATE 40001 retries, and 10 MiB
locked-primary-key accounting.
- Document Tortoise's outer-join query-builder limitation for joined
locking queries.

## Validation

- Hibernate: `./gradlew test` passed.
- Tortoise: Ruff format/lint passed; 124 unit tests and 6 subtests
passed.
- Live Aurora DSQL integration tests were not run locally.

## Related rollout PRs

- Canonical agent guidance: awslabs/agent-plugins#271
- Kiro Power mirror: awslabs/mcp#4607
- Flyway compatibility cleanup: flyway/flyway-community-db-support#149
- ORM adapters: #626
- Samples: aws-samples/aurora-dsql-samples#1821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants