docs(aurora-dsql): update SELECT FOR UPDATE Kiro guidance - #4607
Conversation
|
Review pass 1 Reviewed the Kiro steering rollout finalized in commit Validation: the Kiro steering file is byte-identical to the canonical agent-plugin guidance. |
|
Review pass 2 A fresh 16-reviewer convergence pass was completed, followed by direct current-file verification. No unresolved behavioral or CI-blocking findings remain in commit Final validation: canonical and Kiro steering files are byte-identical, the agent-side deterministic suite passed 60 tests, and the MCP diff passes |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4607 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 1059 1059
Lines 90366 90366
Branches 14614 14614
=======================================
Hits 84343 84343
Misses 3618 3618
Partials 2405 2405 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
## Summary Update Aurora DSQL ORM adapters and guidance for the GA SELECT FOR UPDATE behavior. Part of a coordinated rollout; sibling PR links will be added after all PRs are opened. ## Changes - Update Hibernate guidance and add coverage for non-key predicates with an inner join. - Preserve Hibernate's outer-join limitation. - Enable Tortoise `select_for_update()` while disabling unsupported `FOR NO KEY UPDATE`. - Add Tortoise coverage for non-key filters and both `update_or_create()` paths. - Document commit-time OCC behavior, SQLSTATE 40001 retries, and 10 MiB locked-primary-key accounting. - Document Tortoise's outer-join query-builder limitation for joined locking queries. ## Validation - Hibernate: `./gradlew test` passed. - Tortoise: Ruff format/lint passed; 124 unit tests and 6 subtests passed. - Live Aurora DSQL integration tests were not run locally. ## Related rollout PRs - Canonical agent guidance: awslabs/agent-plugins#271 - Kiro Power mirror: awslabs/mcp#4607 - Flyway compatibility cleanup: flyway/flyway-community-db-support#149 - ORM adapters: #626 - Samples: aws-samples/aurora-dsql-samples#1821
Summary
Mirror the canonical Aurora DSQL SELECT FOR UPDATE guidance in the Kiro Power. This is part of a coordinated rollout; sibling PR links will be added after all PRs are opened.
Changes
User experience
Kiro now recommends supported SELECT FOR UPDATE query shapes and whole-transaction retry behavior without carrying the pre-GA restrictions.
Checklist
Is this a breaking change? N
RFC issue number: N/A
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.
Related rollout PRs