docs(dsql): update SELECT FOR UPDATE guidance and evals - #271
Conversation
|
Review pass 1 Reviewed the rollout diff finalized in commit Validation after fixes: deterministic eval-runner tests passed and the canonical guidance matched the MCP mirror. |
|
Review pass 2 A fresh 16-reviewer convergence pass was run against the post-fix rollout, followed by direct current-file verification of every reported issue. No unresolved behavioral or CI-blocking findings remain in commit Final validation: 60 deterministic eval-runner tests passed; 22 prompts / 93 assertions validate; canonical and MCP steering files are byte-identical; all five diffs pass |
e453c9b to
6708515
Compare
|
LGTM, ran new fleet of reviewers and found no blocking issues or risks. Language audit was clean. Was able to reproduce evals! |
Head branch was pushed to by a user without write access
## Summary Update Aurora DSQL ORM adapters and guidance for the GA SELECT FOR UPDATE behavior. Part of a coordinated rollout; sibling PR links will be added after all PRs are opened. ## Changes - Update Hibernate guidance and add coverage for non-key predicates with an inner join. - Preserve Hibernate's outer-join limitation. - Enable Tortoise `select_for_update()` while disabling unsupported `FOR NO KEY UPDATE`. - Add Tortoise coverage for non-key filters and both `update_or_create()` paths. - Document commit-time OCC behavior, SQLSTATE 40001 retries, and 10 MiB locked-primary-key accounting. - Document Tortoise's outer-join query-builder limitation for joined locking queries. ## Validation - Hibernate: `./gradlew test` passed. - Tortoise: Ruff format/lint passed; 124 unit tests and 6 subtests passed. - Live Aurora DSQL integration tests were not run locally. ## Related rollout PRs - Canonical agent guidance: awslabs/agent-plugins#271 - Kiro Power mirror: awslabs/mcp#4607 - Flyway compatibility cleanup: flyway/flyway-community-db-support#149 - ORM adapters: #626 - Samples: aws-samples/aurora-dsql-samples#1821
Related
Part of a coordinated Aurora DSQL SELECT FOR UPDATE rollout. Sibling PR links will be added after all PRs are opened.
Changes
Validation: 60 deterministic eval-runner tests passed; canonical guidance matches the MCP steering mirror; 22 eval prompts contain 93 assertions. A full model eval run was attempted, but the subject runner timed out after 180 seconds with zero turns on the first eval, so no model-quality result was produced.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.
Related rollout PRs