feat(widget): Rtc transports discovery for widgets - #34393
Conversation
61b88a5 to
78d7c31
Compare
8e3d28b to
78fe92e
Compare
73bffc0 to
edec315
Compare
| return stickyEvents; | ||
| } | ||
|
|
||
| private getSendDelayedEventOpts(delay: number | null, parentDelayId: string | null): SendDelayedEventRequestOpts { |
There was a problem hiding this comment.
Are the delayed event changes because of the matrix-widget-sdk update? They do seem misplaced in this PR?
There was a problem hiding this comment.
Are the delayed event changes because of the
matrix-widget-sdkupdate? They do seem misplaced in this PR?
Yes they are due to the widget-api-changes (remove parent delayed id), but the js-sdk hasn't yet been updated to the MSC changes, so the parentId related types are still around.
There is a js-sdk draft PR matrix-org/matrix-js-sdk#5199
It would be nicer if this landed first :/, but I think they are a bit entangled
@AndrewFerr WDYT?
There was a problem hiding this comment.
It's doubtful that I'll be able to finish that js-sdk PR this week, so as long as it's not a strict requirement of this PR, maybe just charge ahead with this one for now.
There was a problem hiding this comment.
@Half-Shot is it fine to go ahead for you? there will be a follow up PR to finish the clean up of deprecated parent_id thing for delayed event?
There was a problem hiding this comment.
This PR is fairly high-priority and it feels acceptable to me to adapt to the parent ID changes in the same breath as upgrading matrix-widget-api, so I will proceed with getting this merged.
4 participants
Support MSC4515 rtc transport discovery for widgets.
Draft because depends of:
Checklist
public/exportedsymbols have accurate TSDoc documentation.