Rtc: Let the widget driver decide to fallback to well-known or not for rtc discovery. - #34581
Merged
Conversation
Base automatically changed from
valere/rtc/msc4515_widget_rtc_transport_discovery
to
develop
August 10, 2026 14:12
BillCarsonFr
force-pushed
the
valere/rtc/cache_dicovery
branch
from
August 11, 2026 09:33
ffa0043 to
fd4d19b
Compare
BillCarsonFr
marked this pull request as draft
August 11, 2026 17:49
BillCarsonFr
marked this pull request as ready for review
August 11, 2026 21:36
robintown
reviewed
Aug 12, 2026
robintown
approved these changes
Aug 13, 2026
robintown
left a comment
robintown
left a comment
Member
There was a problem hiding this comment.
I've pushed fixes for my feedback directly due to Valere being away.
robintown
force-pushed
the
valere/rtc/cache_dicovery
branch
from
August 13, 2026 08:25
7b02139 to
e98c60d
Compare
Half-Shot
approved these changes
Aug 13, 2026
| }); | ||
| it("Blocks Element Call if transport foci are the wrong type", async () => { | ||
| client._unstable_getRTCTransports.mockResolvedValue([{ type: "anything-else" }]); | ||
| vi.mocked(client.cachedRtcTransports.get).mockReturnValue([{ type: "anything-else" }]); |
Member
There was a problem hiding this comment.
Noting we've changed this to prefill the cache rather than mocking the response, is that going to be more prone to breakage if the behaviour of _unstable_getRTCTransports changes?
| if (foci !== undefined) { | ||
| if (Array.isArray(foci)) | ||
| return foci; // Contents assumed to be valid Transports | ||
| else logger.warn(`org.matrix.msc4143.rtc_foci is not an array in .well-known`); |
Member
There was a problem hiding this comment.
Surprised this passes linting, I thought we always used curly braces for else
Contributor
|
I am merging this. @Half-Shot comments seem to be non blocking. Maybe @robintown or @BillCarsonFr with context might have a look and a potentially add a follow up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #34393
Depends on js-sdk matrix-org/matrix-js-sdk#5470
Element Call will stop doing any call to well-known. It always forward to the widget host using MSC4515.
Now the widget driver will decide to fallback to well-known based on the sdk config
enable_client_well_known_lookupsCallStore is updated to use the new sdk api.
Checklist
public/exportedsymbols have accurate TSDoc documentation.