-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(widget): Rtc transports discovery for widgets #34393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
robintown
merged 8 commits into
develop
from
valere/rtc/msc4515_widget_rtc_transport_discovery
Aug 10, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
78d7c31
feat(widget): Rtc transports discovery for widgets
BillCarsonFr afe7754
fix linter
BillCarsonFr 78fe92e
update matrix-widget-api and js-sdk
BillCarsonFr 6a9b02b
fix eslint-plugin-element-call path
BillCarsonFr edec315
update widget-api: Parent-id delegation is deprectated
BillCarsonFr eb3ff61
Merge branch 'develop' into valere/rtc/msc4515_widget_rtc_transport_d…
BillCarsonFr ea67168
Merge branch 'develop' into valere/rtc/msc4515_widget_rtc_transport_d…
BillCarsonFr 1b25ade
Merge branch 'develop' into valere/rtc/msc4515_widget_rtc_transport_d…
robintown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the delayed event changes because of the
matrix-widget-sdkupdate? They do seem misplaced in this PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes they are due to the widget-api-changes (remove parent delayed id), but the js-sdk hasn't yet been updated to the MSC changes, so the parentId related types are still around.
There is a js-sdk draft PR matrix-org/matrix-js-sdk#5199
It would be nicer if this landed first :/, but I think they are a bit entangled
@AndrewFerr WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's doubtful that I'll be able to finish that js-sdk PR this week, so as long as it's not a strict requirement of this PR, maybe just charge ahead with this one for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Half-Shot is it fine to go ahead for you? there will be a follow up PR to finish the clean up of deprecated parent_id thing for delayed event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is fairly high-priority and it feels acceptable to me to adapt to the parent ID changes in the same breath as upgrading matrix-widget-api, so I will proceed with getting this merged.