Skip to content

python-math #42: feat(delphi): mode collapse C7 — harness identifier purge + flag machinery deletion - #2671

Draft
jucor wants to merge 1 commit into
spr/edge/a4c818c8from
spr/edge/7f42df81
Draft

python-math #42: feat(delphi): mode collapse C7 — harness identifier purge + flag machinery deletion#2671
jucor wants to merge 1 commit into
spr/edge/a4c818c8from
spr/edge/7f42df81

Conversation

@jucor

@jucor jucor commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

What

Final chunk of the GOAL_CUTOVER_READY.md Phase 2 mode collapse — the removal of the engine-mode switch between clojure-legacy (the setting that reproduces the old Clojure engine exactly) and improved behavior. The goal doc's DONE-gate grep (ENGINE_MODE|engine_mode|resolve_engine_mode over delphi/polismath/) now returns ZERO hits.

Changes

  • certify.py (the certification-battery harness): BatteryEntry / derive_schedule_id / parse_battery_entry drop the mode. Schedule ids keep their historical -clojure-legacy suffix via the frozen _LEGACY_SUFFIX literal, and fingerprints bake the same literal into the digest — so recording directories AND every historical key in divergences.json (the ledger of observed Python-vs-Clojure divergences) stay valid. The manifest drops its mode key, riding the same Python-side re-record that the engine change already forced. run_py_driver no longer sets any env; compare_recording_pair drops its dead mode parameter; battery reports and ledger observations drop the mode field (historical ledger values keep theirs on disk).
  • poller_equiv.py (the live Python-vs-Clojure poller equivalence harness): env plumbing deleted (build_py_env / PyPollerRunner / EquivConfig). store.py provenance drops the env record.
  • polismath/utils/engine_mode.py DELETED; scripts/certify_battery.json entries drop the key.
  • Test sweep: engine-mode imports, fixtures, and setenv calls removed across 20 test files; test_engine_mode.py and the two env-guard conftest fixtures deleted; 9 default-mode tests re-pinned to the now-only legacy semantics (arrival-order tid export, inert bans, bucket votes-base, the 1x1 real-math edge case, base-cluster-id (bid) group members, greedy-floor-aware D2c); the D9/D10 comparisons on the vw dataset's cold-start variant now XPASS (parity improved).

Testing

Full suite: 1155 passed / 22 skipped / 44 xfailed / 2 xpassed.

commit-id:7f42df81


Stack:


⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Jul 27, 2026
This was referenced Jul 27, 2026
@jucor
jucor force-pushed the spr/edge/a4c818c8 branch from 198af27 to ced9c07 Compare July 28, 2026 00:11
@jucor
jucor force-pushed the spr/edge/7f42df81 branch from 8a81b06 to 30f0f9b Compare July 28, 2026 00:11
@jucor jucor changed the title feat(delphi): mode collapse C7 — harness identifier purge + flag machinery deletion python-math #42: feat(delphi): mode collapse C7 — harness identifier purge + flag machinery deletion Jul 28, 2026
…purge + flag machinery deletion

## What

Final chunk of the `GOAL_CUTOVER_READY.md` Phase 2 mode collapse — the removal of the engine-mode switch between clojure-legacy (the setting that reproduces the old Clojure engine exactly) and improved behavior. The goal doc's DONE-gate grep (`ENGINE_MODE|engine_mode|resolve_engine_mode` over `delphi/polismath/`) now returns ZERO hits.

## Changes

- `certify.py` (the certification-battery harness): `BatteryEntry` / `derive_schedule_id` / `parse_battery_entry` drop the mode. Schedule ids keep their historical `-clojure-legacy` suffix via the frozen `_LEGACY_SUFFIX` literal, and fingerprints bake the same literal into the digest — so recording directories AND every historical key in `divergences.json` (the ledger of observed Python-vs-Clojure divergences) stay valid. The manifest drops its mode key, riding the same Python-side re-record that the engine change already forced. `run_py_driver` no longer sets any env; `compare_recording_pair` drops its dead mode parameter; battery reports and ledger observations drop the mode field (historical ledger values keep theirs on disk).
- `poller_equiv.py` (the live Python-vs-Clojure poller equivalence harness): env plumbing deleted (`build_py_env` / `PyPollerRunner` / `EquivConfig`). `store.py` provenance drops the env record.
- `polismath/utils/engine_mode.py` DELETED; `scripts/certify_battery.json` entries drop the key.
- Test sweep: engine-mode imports, fixtures, and setenv calls removed across 20 test files; `test_engine_mode.py` and the two env-guard conftest fixtures deleted; 9 default-mode tests re-pinned to the now-only legacy semantics (arrival-order tid export, inert bans, bucket votes-base, the 1x1 real-math edge case, base-cluster-id (bid) group members, greedy-floor-aware D2c); the D9/D10 comparisons on the vw dataset's cold-start variant now XPASS (parity improved).

## Testing

Full suite: 1155 passed / 22 skipped / 44 xfailed / 2 xpassed.

commit-id:7f42df81
@jucor
jucor force-pushed the spr/edge/a4c818c8 branch from ced9c07 to df93b0d Compare July 28, 2026 01:10
@jucor
jucor force-pushed the spr/edge/7f42df81 branch from 30f0f9b to d4aa64f Compare July 28, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant