Skip to content

python-math #41: feat(math): mode collapse C5+C6 — driver mod semantics + poller flag plumbing deleted - #2670

Draft
jucor wants to merge 1 commit into
spr/edge/fe2b0bb2from
spr/edge/a4c818c8
Draft

python-math #41: feat(math): mode collapse C5+C6 — driver mod semantics + poller flag plumbing deleted#2670
jucor wants to merge 1 commit into
spr/edge/fe2b0bb2from
spr/edge/a4c818c8

Conversation

@jucor

@jucor jucor commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

What

Phase 2, chunks C5+C6 of GOAL_CUTOVER_READY.md (the standing goal document for the Python math cutover) — continuing the mode collapse, the removal of the engine-mode switch (POLISMATH_ENGINE_MODE, clojure-legacy vs improved) so only the Clojure-exact behavior remains.

  • Replay driver: the mod_update reducer semantics — a moderation update triggers a votes-recompute first and updates only the moderation sets and watermark, with the effect landing on the next tick — is now the only moderation path. Deleted: the improved-mode update_moderation path, its cumulative mod_state, the emptying-transition guard (_guard_moderation_clear / _mod_dict), and the NotImplementedError raised on improved mode + restart.
  • Poller service (the service that polls Postgres for new votes and runs math ticks): the engine_mode config field, the apply_engine_mode passthrough, and the env import and startup-log field are deleted — the poller no longer reads or writes POLISMATH_ENGINE_MODE. poller/__init__ and env_flags docstrings updated.
  • utils/engine_mode.py itself survives until the harness purge in the next commit: certify.py / store.py / poller_equiv.py still import it.

Testing

Deleted the 3 driver tests and 2 poller tests that pinned the removed paths. 21 driver + 93 poller tests green.

commit-id:a4c818c8


Stack:


⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Jul 27, 2026
This was referenced Jul 27, 2026
@jucor
jucor force-pushed the spr/edge/a4c818c8 branch from 198af27 to ced9c07 Compare July 28, 2026 00:11
@jucor
jucor force-pushed the spr/edge/fe2b0bb2 branch from 2d12f22 to 9f1542f Compare July 28, 2026 00:11
@jucor jucor changed the title feat(math): mode collapse C5+C6 — driver mod semantics + poller flag plumbing deleted python-math #41: feat(math): mode collapse C5+C6 — driver mod semantics + poller flag plumbing deleted Jul 28, 2026
…cs + poller flag plumbing deleted

## What

Phase 2, chunks C5+C6 of `GOAL_CUTOVER_READY.md` (the standing goal document for the Python math cutover) — continuing the mode collapse, the removal of the engine-mode switch (`POLISMATH_ENGINE_MODE`, clojure-legacy vs improved) so only the Clojure-exact behavior remains.

- Replay driver: the `mod_update` reducer semantics — a moderation update triggers a votes-recompute first and updates only the moderation sets and watermark, with the effect landing on the next tick — is now the only moderation path. Deleted: the improved-mode `update_moderation` path, its cumulative `mod_state`, the emptying-transition guard (`_guard_moderation_clear` / `_mod_dict`), and the `NotImplementedError` raised on improved mode + restart.
- Poller service (the service that polls Postgres for new votes and runs math ticks): the `engine_mode` config field, the `apply_engine_mode` passthrough, and the env import and startup-log field are deleted — the poller no longer reads or writes `POLISMATH_ENGINE_MODE`. `poller/__init__` and `env_flags` docstrings updated.
- `utils/engine_mode.py` itself survives until the harness purge in the next commit: `certify.py` / `store.py` / `poller_equiv.py` still import it.

## Testing

Deleted the 3 driver tests and 2 poller tests that pinned the removed paths. 21 driver + 93 poller tests green.

commit-id:a4c818c8
@jucor
jucor force-pushed the spr/edge/a4c818c8 branch from ced9c07 to df93b0d Compare July 28, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant