Skip to content

python-math #34: fix(delphi): Copilot-review triage batch — 16 findings across the stack - #2663

Draft
jucor wants to merge 1 commit into
spr/edge/7f7b9373from
spr/edge/efb914d7
Draft

python-math #34: fix(delphi): Copilot-review triage batch — 16 findings across the stack#2663
jucor wants to merge 1 commit into
spr/edge/7f7b9373from
spr/edge/efb914d7

Conversation

@jucor

@jucor jucor commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

What

Serial application of the triaged APPLY verdicts from the 18 Copilot reviews across the stack — 25 threads in total: 16 applied here, 2 rejected as replicated quirks citing the ledger (CLOJURE_QUIRKS.md), 3 declined, 1 deferred.

Highlights

  • Improved-mode early returns no longer leak stale group_clusterings/group_k_smoother across engine-mode switches (flipping a conversation between clojure-legacy and improved mode) — TDD with the failure observed RED first.
  • The certify cache manifest now hashes comments CSVs (with the required one-time Clojure re-record of the 3 moderation battery entries, done).
  • lru_cache on tree hashes.
  • Battery-entry dataset-mismatch guard.
  • Slug-glob sanitization.
  • The quirk-Q11 clamp now propagates NaN (Q11: the Clojure k-means distance formula's cancellation floor — the clamp must floor only negative cancellation residue to 0.0, never mask NaN).
  • Quirk-Q16 comment projection is always 2-wide (Q16: rank-1 principal components collapse all projections to [0,0]).
  • Shard-bench file-descriptor/kill cleanup.
  • Docstring + test hardening.

Re-certified

Certification battery 20/20 MATCH x2 on this tree (battery_s6_pass{1,2}.log); the 647-test combined gate green.

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

commit-id:efb914d7


Stack:


⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Jul 27, 2026
@jucor
jucor force-pushed the spr/edge/efb914d7 branch from 33b6229 to a25906e Compare July 27, 2026 14:54
This was referenced Jul 27, 2026
@jucor
jucor force-pushed the spr/edge/7f7b9373 branch from b7b349d to d8eb738 Compare July 28, 2026 00:11
@jucor
jucor force-pushed the spr/edge/efb914d7 branch from a25906e to ee94641 Compare July 28, 2026 00:11
@jucor jucor changed the title fix(delphi): Copilot-review triage batch — 16 findings across the stack python-math #34: fix(delphi): Copilot-review triage batch — 16 findings across the stack Jul 28, 2026
…gs across the stack

## What

Serial application of the triaged APPLY verdicts from the 18 Copilot reviews across the stack — 25 threads in total: 16 applied here, 2 rejected as replicated quirks citing the ledger (`CLOJURE_QUIRKS.md`), 3 declined, 1 deferred.

## Highlights

- Improved-mode early returns no longer leak stale `group_clusterings`/`group_k_smoother` across engine-mode switches (flipping a conversation between clojure-legacy and improved mode) — TDD with the failure observed RED first.
- The certify cache manifest now hashes comments CSVs (with the required one-time Clojure re-record of the 3 moderation battery entries, done).
- `lru_cache` on tree hashes.
- Battery-entry dataset-mismatch guard.
- Slug-glob sanitization.
- The quirk-Q11 clamp now propagates NaN (Q11: the Clojure k-means distance formula's cancellation floor — the clamp must floor only negative cancellation residue to 0.0, never mask NaN).
- Quirk-Q16 comment projection is always 2-wide (Q16: rank-1 principal components collapse all projections to [0,0]).
- Shard-bench file-descriptor/kill cleanup.
- Docstring + test hardening.

## Re-certified

Certification battery 20/20 MATCH x2 on this tree (`battery_s6_pass{1,2}.log`); the 647-test combined gate green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

commit-id:efb914d7
@jucor
jucor force-pushed the spr/edge/7f7b9373 branch from d8eb738 to db56126 Compare July 28, 2026 01:10
@jucor
jucor force-pushed the spr/edge/efb914d7 branch from ee94641 to 9cb0337 Compare July 28, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant