Refactor CMake with JRL CMake Modules v2 - #794
Open
ahoarau wants to merge 47 commits into
Open
Conversation
ahoarau
marked this pull request as draft
December 11, 2025 16:39
ahoarau
force-pushed
the
jrl-next
branch
2 times, most recently
from
January 12, 2026 16:39
075411a to
e6124d7
Compare
ahoarau
force-pushed
the
jrl-next
branch
3 times, most recently
from
February 20, 2026 09:38
b8bf15e to
f604bdc
Compare
jorisv
approved these changes
May 29, 2026
jorisv
requested changes
May 29, 2026
jorisv
left a comment
jorisv
left a comment
Contributor
There was a problem hiding this comment.
Bad button, I request some changes ;)
jorisv
reviewed
Jun 2, 2026
jorisv
reviewed
Jun 2, 2026
jorisv
reviewed
Jun 25, 2026
jorisv
reviewed
Jun 25, 2026
jorisv
reviewed
Jun 25, 2026
jorisv
requested changes
Jun 25, 2026
ahoarau
added a commit
to ahoarau/coal
that referenced
this pull request
Jul 29, 2026
- Upgrade CMake build system to JRL CMake Modules v2 - Integrate cmake/get-jrl-cmakemodules.cmake downloader - Use target-based modern CMake for coal, python, python-nb, doc, and test suites - Condition coal-hpp-fcl-compatibility target, headers, and export component on COAL_BACKWARD_COMPATIBILITY_WITH_HPP_FCL (fixes PR coal-library#794 review feedback) - Require C++17 minimum standard
ahoarau
added a commit
to ahoarau/coal
that referenced
this pull request
Jul 29, 2026
- Upgrade CMake build system to JRL CMake Modules v2 - Integrate cmake/get-jrl-cmakemodules.cmake downloader - Use target-based modern CMake for coal, python, python-nb, doc, and test suites - Condition coal-hpp-fcl-compatibility target, headers, and export component on COAL_BACKWARD_COMPATIBILITY_WITH_HPP_FCL (fixes PR coal-library#794 review feedback) - Require C++17 minimum standard
ahoarau
added a commit
to ahoarau/coal
that referenced
this pull request
Jul 29, 2026
- Upgrade CMake build system to JRL CMake Modules v2 - Integrate cmake/get-jrl-cmakemodules.cmake downloader pointing to official jrl-umi3218/jrl-cmakemodules master branch - Use target-based modern CMake for coal, python, python-nb, doc, and test suites - Condition coal-hpp-fcl-compatibility target, headers, and export component on COAL_BACKWARD_COMPATIBILITY_WITH_HPP_FCL (fixes PR coal-library#794 review feedback) - Require C++17 minimum standard
ahoarau
added a commit
to ahoarau/coal
that referenced
this pull request
Jul 29, 2026
- Upgrade CMake build system to JRL CMake Modules v2 - Integrate cmake/get-jrl-cmakemodules.cmake downloader pointing to official jrl-umi3218/jrl-cmakemodules master branch - Use target-based modern CMake for coal, python, python-nb, doc, and test suites - Condition coal-hpp-fcl-compatibility target, headers, and export component on COAL_BACKWARD_COMPATIBILITY_WITH_HPP_FCL (fixes PR coal-library#794 review feedback) - Require C++17 minimum standard
Superseded by CMake COMPONENT export.
Remove python __init__.py and windows_dll_manager.py files which are now auto-generated by JRL CMake Modules v2. Also remove unused test config header.
Pure rename of test/*.py, test/*.cpp and related files into cpp, python, benchmark, and utility subdirectories. No content changes.
Reorganize test suite into cpp, python, benchmark, packaging, and utility subdirectories.
- Upgrade CMake build system to JRL CMake Modules v2 - Integrate cmake/get-jrl-cmakemodules.cmake downloader pointing to official jrl-umi3218/jrl-cmakemodules master branch - Use target-based modern CMake for coal, python, python-nb, doc, and test suites - Condition coal-hpp-fcl-compatibility target, headers, and export component on COAL_BACKWARD_COMPATIBILITY_WITH_HPP_FCL - Require C++17 minimum standard
__cpluscplus is needed to build
This was referenced Aug 3, 2026
ahoarau
marked this pull request as ready for review
August 4, 2026 09:47
jorisv
previously approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a full rewrite of the CMake files with the JRL CMake Modules v2.
c++17minimum required