Rename `Phase2Timing_resources` to `resources` by Parsifal-2045 · Pull Request #51766 · cms-sw/cmssw

Parsifal-2045 · 2026-08-27T08:45:22Z

PR description:

Title says it all, some forward-looking changes in preparation for the reworked benchmark scripts cms-patatrack/patatrack-scripts#61.

PR validation:

Running any Phase-2 configuration (that enables the FastTimerService) now correctly produces resources.json instead of Phase2Timing_resources.json

Note: this PR needs to be tested together with cms-sw/cms-bot#2828 to keep the bot's timing tests functional

cmsbuild · 2026-08-27T08:45:45Z

cms-bot internal usage

cmsbuild · 2026-08-27T08:48:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51766/50734

There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/HLT_75e33/test/runHLTTiming.sh modified in PR(s): add input benchmark to Phase 2 HLT timing test #51564

cmsbuild · 2026-08-27T08:49:13Z

A new Pull Request was created by @Parsifal-2045 for master.

It involves the following packages:

HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2026-08-27T08:52:49Z

test parameters:

enable = hlt_p2_timing
pull_request = Rename Phase2Timing_resources to resources cms-bot#2828

mmusich · 2026-08-27T08:53:25Z

@cmsbuild, please test

Parsifal-2045 · 2026-08-31T13:34:21Z

I think the tests got stuck here. @smuzaffar can you please have a look?

cmsbuild · 2026-08-31T17:48:48Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ec3cb/55557/summary.html
COMMIT: 556d202
CMSSW: CMSSW_20_1_X_2026-08-26-2300/el9_amd64_gcc14
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51766/55557/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3592269
DQMHistoTests: Total failures: 44
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3592207
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 195 log files, 163 edm output root files, 45 DQM output files
TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 98 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 173739
DQMHistoTests: Total failures: 9179
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 164560
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 25 log files, 20 edm output root files, 7 DQM output files
TriggerResults: no differences found

AMD_W7900 Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 58 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 173739
DQMHistoTests: Total failures: 8676
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 165063
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 25 log files, 20 edm output root files, 7 DQM output files
TriggerResults: no differences found

NVIDIA_H100 Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 127 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 173739
DQMHistoTests: Total failures: 9836
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 163903
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 25 log files, 20 edm output root files, 7 DQM output files
TriggerResults: no differences found

NVIDIA_L4 Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 117 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 173739
DQMHistoTests: Total failures: 9217
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 164522
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 25 log files, 20 edm output root files, 7 DQM output files
TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 106 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 173739
DQMHistoTests: Total failures: 9355
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 164384
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 25 log files, 20 edm output root files, 7 DQM output files
TriggerResults: no differences found

NVIDIA_T4 Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 76 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 173739
DQMHistoTests: Total failures: 8325
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 165414
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 25 log files, 20 edm output root files, 7 DQM output files
TriggerResults: no differences found

Max Memory Comparisons exceeding threshold NVIDIA_L4

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...

Error: Workflow 37634.7503_TTbar_14TeV+Run4D127_HLTHeterogeneousValid step2 max memory diff 38.1 exceeds +/- 30.0 MiB

Max Memory Comparisons exceeding threshold NVIDIA_L40S

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...

Error: Workflow 37634.7503_TTbar_14TeV+Run4D127_HLTHeterogeneousValid step2 max memory diff -191.8 exceeds +/- 30.0 MiB

mmusich · 2026-09-01T07:04:27Z

+hlt

cmsbuild · 2026-09-01T07:04:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cms-bot#2828

mmusich · 2026-09-01T07:05:05Z

hold

this needs to go in with Rename Phase2Timing_resources to resources cms-bot#2828 (which will need a rebase after make sure to use the correct version of compareMemoryProfiles.py cms-bot#2829)

cmsbuild · 2026-09-01T07:05:24Z

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

mmusich · 2026-09-02T06:52:56Z

unhold

blocking PRs are merged

cmsbuild · 2026-09-02T06:53:20Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cms-bot#2828

mandrenguyen · 2026-09-03T07:05:53Z

+1

Rename Phase2Timing_resources to resources

556d202

cmsbuild added this to the CMSSW_20_1_X milestone Aug 27, 2026

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Aug 27, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 27, 2026

cmsbuild added tests-started requires-external and removed tests-pending labels Aug 27, 2026

mmusich mentioned this pull request Aug 27, 2026

Rename Phase2Timing_resources to resources cms-sw/cms-bot#2828

Merged

cmsbuild added tests-approved and removed tests-started labels Aug 31, 2026

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Sep 1, 2026

cmsbuild added pending-signatures hold and removed fully-signed labels Sep 1, 2026

cmsbuild added fully-signed and removed pending-signatures hold labels Sep 2, 2026

cmsbuild added orp-approved and removed orp-pending labels Sep 3, 2026

cmsbuild merged commit ef31f5d into cms-sw:master Sep 3, 2026
30 checks passed

This was referenced Sep 3, 2026

Massive update of Python Packages cms-sw/cmsdist#10821

Open

md5.h rename to edm_md5 to avoid collision #51818

Open

md5: To avoid collision: rename md5.h to edm_d5 cms-sw/cmsdist#10825

Open

Parsifal-2045 deleted the renamePhase2TimingResources branch September 4, 2026 16:55

Uh oh!

Conversation

Parsifal-2045 commented Aug 27, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Aug 27, 2026

Uh oh!

cmsbuild commented Aug 27, 2026

Uh oh!

mmusich commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmusich commented Aug 27, 2026

Uh oh!

Parsifal-2045 commented Aug 31, 2026

Uh oh!

cmsbuild commented Aug 31, 2026

Comparison Summary

AMD_MI300X Comparison Summary

AMD_W7900 Comparison Summary

NVIDIA_H100 Comparison Summary

NVIDIA_L4 Comparison Summary

NVIDIA_L40S Comparison Summary

NVIDIA_T4 Comparison Summary

Max Memory Comparisons exceeding threshold NVIDIA_L4

Max Memory Comparisons exceeding threshold NVIDIA_L40S

Uh oh!

mmusich commented Sep 1, 2026

Uh oh!

cmsbuild commented Sep 1, 2026

Uh oh!

mmusich commented Sep 1, 2026

Uh oh!

cmsbuild commented Sep 1, 2026

Uh oh!

mmusich commented Sep 2, 2026

Uh oh!

cmsbuild commented Sep 2, 2026

Uh oh!

mandrenguyen commented Sep 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented Aug 27, 2026 •

edited

Loading

mmusich commented Aug 27, 2026 •

edited

Loading