md5.h rename to edm_md5 to avoid collision

[smuzaffar]

As requested in cms-externals/md5#2 , this PR proposes to use edm_md5.h. This needs to go in with cms-sw/cmsdist#10825

[cmsbuild]

cms-bot internal usage

[smuzaffar]

code-checks with cms.week1.PR_dee6b702/100.0-3059cff9e76233642776e3c648d861fb

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51818/50812

• There are other open Pull requests which might conflict with changes you have proposed:
  • File CalibCalorimetry/HcalTPGAlgos/src/LutXml.cc modified in PR(s): Cleanup within HCAL TPG Coder Realm #51808
  • File CalibCalorimetry/HcalTPGIO/src/HcalLuttoDB.cc modified in PR(s): Cleanup within HCAL TPG Coder Realm #51808

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• CalibCalorimetry/HcalTPGAlgos (alca, l1)
• CalibCalorimetry/HcalTPGIO (alca, l1)
• FWCore/Utilities (core)

@Alejandro1400, @BenjaminRS, @Dr15Jones, @EltonSh, @JanChyczynski, @arunhep, @cmsbuild, @makortel, @perrotta, @quinnanm, @smuzaffar can you please review it and eventually sign? Thanks.
@abdoulline, @bsunanda, @felicepantaleo, @makortel, @mmusich, @tocheng, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

test parameters:

• pull_request = md5: To avoid collision: rename md5.h to edm_md5 cmsdist#10825

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-413d29/55675/summary.html
COMMIT: 3add2cc
CMSSW: CMSSW_20_1_X_2026-09-02-2300/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51818/55675/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw Update Boost version to 1.92.0 in spec file cmsdist#10819
• @Kirutheeka7 Updating Phase-2 FastSim Tracker material parameters and workflow #51604
• @felicepantaleo Truth Graph: Introducing Levels #51716
• @tvami Drop clamped pixels, bounds-check cluster ids in SiPixelClusterizer #51753
• @Parsifal-2045 Rename Phase2Timing_resources to resources #51766
• @bsunanda Phase2-hgx368T Remove cyclic dependency between Geometry/HGCalGeometry and Geometry/CaloTopology #51800
• @smuzaffar [fmt 12.2] use fmt/format.h instead of heavy fmt/core.h #51801

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-413d29/55675/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-413d29/55675/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3592269
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3592231
• DQMHistoTests: Total skipped: 18
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 195 log files, 163 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[makortel]

---> test TestIOPoolInputNoParentDictionary had ERRORS

The test fails with several errors like

In file included from src/FWCore/Utilities/src/Digest.cc:6:
src/FWCore/Utilities/interface/Digest.h:4:10: fatal error: edm_md5.h: No such file or directory
    4 | #include <edm_md5.h>
      |          ^~~~~~~~~~~
compilation terminated.

@smuzaffar Do I guess correctly that the scram b inside the test

cmssw/IOPool/Input/test/testNoParentDictionary.sh

Line 68 in e3685ee

(eval $(scram run -sh) ; scram build -j $(nproc))

doesn't get the updated external setup in the PR test?

[smuzaffar]

@makortel , yes the test just creates a freash dev area ( with old externals ) so it will not have the edm_md5.h file. This is known issue with this unit test, it fails when we update root with newer version number. I suggest we ignore this error and get this change ( along with cmsdist ) in to IB.

[smuzaffar]

note that this unit tests copies the local FWCore/Utilities in to newly created scram dev area. So here in this PR it uses new FWCore/Utilities ( where we have edm_md5.h ) while the externals for the original IB

[makortel]

ignore tests-rejected with manual-override

Thanks for the explanation

[makortel]

+core

[perrotta]

+alca

[cmsbuild]

REMINDER @mandrenguyen, @sextonkennedy, @ftenchini: This PR was tested with cms-sw/cmsdist#10825, please check if they should be merged together

[smuzaffar]

@cms-sw/l1-l2 can you please review this technical change ?

[BenjaminRS]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#10825