Skip to content

md5: To avoid collision: rename md5.h to edm_md5 - #10825

Open
smuzaffar wants to merge 1 commit into
IB/CMSSW_20_1_X/masterfrom
edm_md5
Open

md5: To avoid collision: rename md5.h to edm_md5#10825
smuzaffar wants to merge 1 commit into
IB/CMSSW_20_1_X/masterfrom
edm_md5

Conversation

@smuzaffar

Copy link
Copy Markdown
Contributor

Resolves cms-externals/md5#2

md5.h is rename to edm_md5 and all functions are moved under edm_md5 namespace

@cmsbuild

cmsbuild commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_20_1_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please build

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please test with cms-sw/cmssw#51818

@cmsbuild

cmsbuild commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3d54d/55674/summary.html
COMMIT: 8baff05
CMSSW: CMSSW_20_1_X_2026-09-02-2300/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10825/55674/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3d54d/55674/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3d54d/55674/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3592269
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3592215
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@smuzaffar

Copy link
Copy Markdown
Contributor Author

ignore tests-rejected with manual-override

@smuzaffar

Copy link
Copy Markdown
Contributor Author

+externals

this should go in with cms-sw/cmssw#51818

@cmsbuild

cmsbuild commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_20_1_X/master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#51818

@cmsbuild

cmsbuild commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

REMINDER @mandrenguyen, @ftenchini, @sextonkennedy: This PR was tested with cms-sw/cmssw#51818, please check if they should be merged together

@smuzaffar smuzaffar changed the title md5: To avoid collision: rename md5.h to edm_d5 md5: To avoid collision: rename md5.h to edm_md5 Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename the header to avoid collisions

2 participants