Repository navigation
Conversation
Rebase the graphics proposal onto upstream b42ef24 without carrying the historical macOS merge chain. Includes the compiler/runtime prerequisite from PR boykopovar#1835 and the still-required macOS foundation from mugurc/macos-port at 21930ce; those platform changes remain until their upstream PRs land. Preserve upstream starting-quad folding and the qualified vertex lane rule. Keep x87-dependent Math.cpp outside the optional ARM64 graphics closure rather than weakening its ABI assertion.
This was referenced Oct 15, 2026
Merged
11 tasks done
11 tasks done
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Qualify finite native dispatch from contiguous relative relocations in an explicitly immutable table. A supported RIP-relative LEA followed by an indexed memory CALL/JMP derives the target set; CALL targets need compatible qualified internal ABIs, while JMP targets must be instruction boundaries in the same function. Bounds/alignment are checked before loading a target and membership before dispatch. Existing declared callbacks also gain membership checks.
Optimized public C consumers additionally require immediate ROL/ROR, BSWAP and a bounded SSE2 integer subset. These implement instruction semantics; they do not add a runtime x86 translator or a general SIMD reconstruction optimizer. Mutable tables, arbitrary register jumps, relative 32-bit jump tables, unknown target ABIs and variable rotate counts still reject.
Incremental review: yabanana/AnyPS5@feature/aot-optimized-facts...feature/aot-finite-dispatch
Tested
Latest integration checkpoint (12 October): aligned with main
2f4cc8983, including the new component technical-debt layout. The final combined stack with the separate C++ follow-up #4718 passed 588 compiler/relinker/runtime checks and 26 native integrations on Apple Silicon. Rebuilt cube AOT/reference still match all eight RGB frames after 600 flips each; controller and typed module-bundle acceptance pass. These are local results; hosted CI is running on the updated head. Full Linux/Windows builds still require maintainer dispatch.Integration checkpoint, 12 October: merged main
fe66af13ethrough the dependency stack and requalified affected provider identities after reviewing their implementations. The final combined stack passed 526 compiler/relinker/runtime cases, 26 native integration cases, the rebuilt graphics pair (600 flips each, teardown, eight exact RGB frames), controller O2 and SHA/memcmp O0/O2 checks on Apple Silicon. Hosted checks refer to the new head and remain separate from these local results. Full Linux/Windows builds require maintainer dispatch.Validation: Apple ARM64. Six finite-dispatch execution/rejection tests cover calls, local jumps, out-of-range indices, incompatible ABIs, instruction-overlap targets, alias writes and undeclared callbacks. Rotate/byte-swap probes cover widths, partial registers, counts and defined flags; SSE2 lane/shift probes compare against x86 execution under Rosetta. Instruction semantics follow the corresponding Intel SDM Volume 2 entries. The final dependent stack passes 494 compiler/relinker tests, 24 native tests, pad_input O2, external components O0/O2 and exact graphics regression; reproduction is in the consumer PR. Hosted CI is pending.
Checklist