Repository navigation
Conversation
This was referenced Oct 15, 2026
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
11 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clarifies that
--modulesreads original ELF modules. Converted.guest.prxfiles are PE outputs; their PS5 imports are already recorded in the per-module registry JSON passed as positional input. If a converted PE is passed to--modules, the error now explains the expected input and where to get the imports.Addresses the usage ambiguity reported in #6378 without treating PE host exports as PS5 module exports.
Tested
Linux (Python 3):
python3 -m unittest tools.tests.test_import_audit— 84 tests, 1 skipped..guest.prxfilename and the actionable error.python3 tools/check_conventions.py --base upstream/main— passed.git diff --check— passed.Checklist
main; no other open PR implements the same behavior.mdfiles or images added to the repository