Repository navigation
fix(agc): limit copied-writer waits to copied ranges - #6365
Open
eljackjoestar-cmd wants to merge 1 commit into
Open
eljackjoestar-cmd wants to merge 1 commit into
eljackjoestar-cmd wants to merge 1 commit into
Conversation
This was referenced Oct 15, 2026
This was referenced Oct 15, 2026
Closed
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
Tested on Linux x86-64 (Release build, lavapipe / llvmpipe LLVM 20.1.2), with 81ef1ff merged into main ce991f1:
AI-assisted: yes (Claude Code) |
11 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A producer with directly imported and CPU-copied writable buffers is registered as a copied writer. Matching all its writes in
CompletePendingCpuWritesmakes binding its direct buffer complete an unrelated CPU write-back. Match only copied writes, retaining existing label checks and GPU ordering.The regression covers mixed producers in both dispatch and draw copied-writer registries: the direct range leaves completion pending, while the copied range completes it. It fails with the original predicate and passes with this change.
Tested
Windows 10.0.26300, NVIDIA RTX 5070, driver 617.14. Release patched-library build; 17 focused checks passed: copied/direct ordering, import watch on both queue families, pending-write snapshot, address-space pending writes, storage/buffer ordering, in-place draw inputs, graphics, all three pipeline-library modes, native depth clears/refusals/retirement, HTILE writes and queue-idle waiting.
Tests ran in a gameplay integration of main6359e3466 with retained pending #5872/#5870/#6216/#6197/#6178 and local bring-up diagnostics, which are not patch dependencies. Its pre-existing
agc_storage_split_writebackfixture takes #6197's GPU-direct joined-import path and fails the same CPU-path expectation with and without this change. Lost Soul Aside still has severe FPS/memory problems; no overall speedup or title unblock is claimed.The branch contains only the predicate and regression, based on main6359e3466. Overlap scanning checked 561 open PRs; manual comparison of the affected functions in the 38 uncomparable PRs found no duplicate.
Checklist
main; no other open PR implements the same functions.mdfiles or images added to the repository