Skip to content

direwolf: fix dependency stuff - #484861

Closed
Pandapip1 wants to merge 2 commits into
NixOS:masterfrom
Pandapip1:direwolf-darwin-fix
Closed

direwolf: fix dependency stuff#484861
Pandapip1 wants to merge 2 commits into
NixOS:masterfrom
Pandapip1:direwolf-darwin-fix

Conversation

@Pandapip1

@Pandapip1 Pandapip1 commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Should fix #479117 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@Pandapip1
direwolf-unstable: fix incorrect default gpsd support
450fc24
@Pandapip1
direwolf: fix dependencies
54e4ef5 
It looks like there were some missing / incorrectly flagged dependencies
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jan 28, 2026
@PandapipBot

PandapipBot commented Jan 28, 2026

Copy link
Copy Markdown

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 484861
Commit: 54e4ef56f9f7aaf2b90aee07e911d4d4f1f21fb1 (subsequent changes)
Merge: b46027aa2286a43bac8a9386d443c180e0dfafd5

Logs: https://github.com/PandapipBot/nixpkgs-review-gha/actions/runs/21455595717

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-484861-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://pandapipbot.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  pandapipbot.cachix.org-1:KoP8jkkE4Imi5PWXZMCqLgbp++61etXQItI4bcZVBNo=
  ' \
  /nix/store/nv07b2qvlfsp8vixwmbjk0x6s6aw4m98-direwolf-1.8.1-unstable-2026-01-08 \
  /nix/store/yzyxrjw5z6gwaah13i77drbv023dpa8p-direwolf-1.8.1 \
  /nix/store/y6fflzhsrshmj2j1pv1mbqw0qzsbx0ak-openwebrx-1.2.2 \
  /nix/store/maa5c5jznz7ybr2sxs3yy7hqnh77w5r4-openwebrx-1.2.2-dist
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-484861-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://pandapipbot.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  pandapipbot.cachix.org-1:KoP8jkkE4Imi5PWXZMCqLgbp++61etXQItI4bcZVBNo=
  ' \
  /nix/store/8zixq8595r62fckq6s6bzx06yd9r7jvm-direwolf-1.8.1 \
  /nix/store/pksfj35bwbnc85zyj3bfbfwy4p6vxv7m-direwolf-1.8.1-unstable-2026-01-08 \
  /nix/store/mwrljq0ivdhym7yn8madm4cpsqmc3ajx-openwebrx-1.2.2 \
  /nix/store/64d63nd7np4fjv0sx9xj1hrjd8vvjwfr-openwebrx-1.2.2-dist
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-484861-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://pandapipbot.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  pandapipbot.cachix.org-1:KoP8jkkE4Imi5PWXZMCqLgbp++61etXQItI4bcZVBNo=
  ' \
  /nix/store/zxgzfg2lwxhj7dlla4f50f8da7jfd61a-direwolf-1.8.1-unstable-2026-01-08 \
  /nix/store/h27jsi68s5sxnkikqbnrmrqz5z9bbwyv-direwolf-1.8.1
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-484861-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://pandapipbot.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  pandapipbot.cachix.org-1:KoP8jkkE4Imi5PWXZMCqLgbp++61etXQItI4bcZVBNo=
  ' \
  /nix/store/hfxhwygglncbvvcqfinwjq2gm7s54y03-direwolf-1.8.1 \
  /nix/store/wfpyxv1p6a65vr0an7ji6v7f7gp7i50w-direwolf-1.8.1-unstable-2026-01-08

x86_64-linux

✅ 4 packages built:
  • direwolf
  • direwolf-unstable
  • openwebrx
  • openwebrx.dist

aarch64-linux

✅ 4 packages built:
  • direwolf
  • direwolf-unstable
  • openwebrx
  • openwebrx.dist

x86_64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • direwolf
  • direwolf-unstable

aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • direwolf
  • direwolf-unstable

sarcasticadmin
sarcasticadmin reviewed Feb 3, 2026
View reviewed changes
Comment thread pkgs/by-name/di/direwolf/package.nix
avahi
udev
libcap
libgpiod

@sarcasticadmin sarcasticadmin Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpiod seems optional? https://github.com/wb2osz/direwolf/blob/a231971a652bfb574a4bae9a5d875fbce53d2267/CMakeLists.txt#L347

Seems like it could be being a boolean and defaulted to false

Comment thread pkgs/by-name/di/direwolf/package.nix
]
++ lib.optionals stdenv.hostPlatform.isLinux [
alsa-lib
avahi

@sarcasticadmin sarcasticadmin Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avahi seems optional as well https://github.com/wb2osz/direwolf/blob/a231971a652bfb574a4bae9a5d875fbce53d2267/CMakeLists.txt#L389

Comment thread pkgs/by-name/di/direwolf/package.nix
buildInputs = [
hidapi
libusb1
portaudio

@sarcasticadmin sarcasticadmin Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt portaudio only required for darwin? https://github.com/wb2osz/direwolf/blob/a231971a652bfb574a4bae9a5d875fbce53d2267/CMakeLists.txt#L403

@Pandapip1 Pandapip1 Feb 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the BSDs too IIUC. But my understanding is that it also works on linux, and if it isn't used it won't get linked anyway.

Comment thread pkgs/by-name/di/direwolf/package.nix
espeak
];
buildInputs = [
hidapi

@sarcasticadmin sarcasticadmin Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should CUSTOM_EXTERNAL_DIR (https://github.com/wb2osz/direwolf/blob/a231971a652bfb574a4bae9a5d875fbce53d2267/CMakeLists.txt#L78) be set? since it seems like direwolf's embedded its own hidapi source: https://github.com/wb2osz/direwolf/tree/1.8.1/external/hidapi

Comment thread pkgs/by-name/di/direwolf/package.nix
hidapi
libusb1
portaudio
sndio

@sarcasticadmin sarcasticadmin Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt sndio specific to darwin and openbsd? https://github.com/wb2osz/direwolf/blob/a231971a652bfb574a4bae9a5d875fbce53d2267/CMakeLists.txt#L396C1-L396C7

@sarcasticadmin sarcasticadmin mentioned this pull request Mar 10, 2026
Merged
13 tasks
@sarcasticadmin

sarcasticadmin commented Mar 10, 2026

Copy link
Copy Markdown
Member

@Pandapip1 can you review: #498631 this should work similarly but honor the deps per platform.

@Pandapip1 Pandapip1 closed this Aug 10, 2026
@Pandapip1
Pandapip1 deleted the direwolf-darwin-fix branch August 10, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lasandell lasandell Awaiting requested review from lasandell
1 more reviewer
@sarcasticadmin sarcasticadmin sarcasticadmin left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pandapip1 @PandapipBot @sarcasticadmin