direwolf: include darwin and BSD deps

[sarcasticadmin]

Things done

This fixes the build of direwolf on darwin:

$ nix build .#direwolf
...
       > CMake Error in src/CMakeLists.txt:
       >   Found relative path while evaluating include directories of "appserver":
       >
       >     "HIDAPI_INCLUDE_DIRS-NOTFOUND"
       >
       >
       >
       > -- Generating done (0.1s)
       > CMake Warning:
       >   Manually-specified variables were not used by the project:
       >
       >     BUILD_TESTING
       >     CMAKE_EXPORT_NO_PACKAGE_REGISTRY
       >     CMAKE_INSTALL_BINDIR
       >     CMAKE_INSTALL_DOCDIR
       >     CMAKE_INSTALL_INCLUDEDIR
       >     CMAKE_INSTALL_INFODIR
       >     CMAKE_INSTALL_LIBDIR
       >     CMAKE_INSTALL_LIBEXECDIR
       >     CMAKE_INSTALL_LOCALEDIR
       >     CMAKE_INSTALL_MANDIR
       >     CMAKE_INSTALL_SBINDIR
       >
       >
       > CMake Generate step failed.  Build files cannot be regenerated correctly.
       For full logs, run:

Supersedes: #484861

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[DaGenix]

Also builds for me on aarch64-darwin

[Pandapip1]

I'm approving this just so we can finally get it merged but I'd just like it to be known that I am not a fan of shipping packages that are intentionally missing functionality for no good reason (see the Debian KeePassXC debacle for an example of this for a popular package on a popular distro; IIUC what you're suggesting we do with direwolf is an exact analog).

"Fewer dependencies" is not a good reason. If a dependency is large (like GTK), reducing closure size by a not insignificant amount is a good reason and while I still don't agree with keeping it disabled by default I can at least accept that there is a logical reason for doing so. But avahi is small; if you're running a system where the difference between bringing avahi in and keeping it out matters, then you can set the option we provide and build it yourself. I wouldn't even be opposed to a direwolfMinimal package so we can provide prebuilt binaries.

I will be submitting a follow-up PR to move this back to the sensible default once this is merged.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/3230

[sarcasticadmin]

"Fewer dependencies" is not a good reason. If a dependency is large (like GTK), reducing closure size by a not insignificant amount is a good reason and while I still don't agree with keeping it disabled by default I can at least accept that there is a logical reason for doing so. But avahi is small; if you're running a system where the difference between bringing avahi in and keeping it out matters, then you can set the option we provide and build it yourself. I wouldn't even be opposed to a direwolfMinimal package so we can provide prebuilt binaries.

I will be submitting a follow-up PR to move this back to the sensible default once this is merged.

cups has a similar default option in nixpkgs:

nixpkgs/pkgs/by-name/cu/cups/package.nix

Line 20 in cbfa1f1

avahi ? null,

[Pandapip1]

Yea, that still has avahi enabled by default. It just also handles the situation where it's manually removed gracefully. The package ? null syntax in a callPackage will mean that if package exists, it will be passed, and if it doesn't, null will be passed. avahi does exist, so it gets passed by default. I also know this because I rely on CUPS's mDNS/avahi integration, which does work.

[sarcasticadmin]

Yea, that still has avahi enabled by default. It just also handles the situation where it's manually removed gracefully. The package ? null syntax in a callPackage will mean that if package exists, it will be passed, and if it doesn't, null will be passed. avahi does exist, so it gets passed by default. I also know this because I rely on CUPS's mDNS/avahi integration, which does work.

yep, direwolf now been enabled by default to align

[sarcasticadmin]

also rebased since this was so old

[Pandapip1]

TY!

[SuperSandroBot]

✅ nixpkgs-review result

Generated using nixpkgs-review-gha (0d7e614)

Command: nixpkgs-review pr 498631
Commit: fd9663a59e42974af81373dfac61ea26d1f77e67 (subsequent changes)
Merge: d72ae0b6e23955465cf8408eadb4747dcba15daa

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/31433332567/attempts/1

---

x86_64-linux

✅ 2 packages built:

• direwolf
• direwolf-unstable

---

aarch64-linux

✅ 2 packages built:

• direwolf
• direwolf-unstable

---

aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:

• direwolf
• direwolf-unstable