Skip to content

direwolf: fix dependency stuff #484861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pandapip1 wants to merge 2 commits into from
Closed

direwolf: fix dependency stuff #484861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
450fc24
direwolf-unstable: fix incorrect default gpsd support
Pandapip1 Jan 22, 2026
54e4ef5
direwolf: fix dependencies
Pandapip1 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/by-name/di/direwolf-unstable/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
direwolf,
nix-update-script,
hamlibSupport ? true,
gpsdSupport ? true,
gpsdSupport ? false,
extraScripts ? false,
}:

Expand Down
45 changes: 29 additions & 16 deletions pkgs/by-name/di/direwolf/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,21 @@
fetchpatch,
cmake,
alsa-lib,
avahi,
gpsd,
gpsdSupport ? false,
hamlib_4,
hamlib ? hamlib_4,
hamlibSupport ? true,
hidapi,
libcap,
libgpiod,
libusb1,
perl,
pkg-config,
portaudio,
python3,
sndio,
espeak,
udev,
udevCheckHook,
Expand All @@ -32,26 +39,32 @@ stdenv.mkDerivation (finalAttrs: {
hash = "sha256-CCJr3l4RxYZLrdCRwio64EzpDyErlV9JDOXD6TH8p9o=";
};

strictDeps = true;
nativeBuildInputs = [
cmake
pkg-config
udevCheckHook
];

strictDeps = true;

buildInputs =
lib.optionals stdenv.hostPlatform.isLinux [
alsa-lib
udev
]
++ lib.optionals stdenv.hostPlatform.isDarwin [ portaudio ]
++ lib.optionals gpsdSupport [ gpsd ]
++ lib.optionals hamlibSupport [ hamlib ]
++ lib.optionals extraScripts [
python3
perl
espeak
];
buildInputs = [
hidapi

@sarcasticadmin sarcasticadmin Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should CUSTOM_EXTERNAL_DIR (https://github.com/wb2osz/direwolf/blob/a231971a652bfb574a4bae9a5d875fbce53d2267/CMakeLists.txt#L78) be set? since it seems like direwolf's embedded its own hidapi source: https://github.com/wb2osz/direwolf/tree/1.8.1/external/hidapi

libusb1
portaudio

@sarcasticadmin sarcasticadmin Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt portaudio only required for darwin? https://github.com/wb2osz/direwolf/blob/a231971a652bfb574a4bae9a5d875fbce53d2267/CMakeLists.txt#L403

@Pandapip1 Pandapip1 Feb 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the BSDs too IIUC. But my understanding is that it also works on linux, and if it isn't used it won't get linked anyway.

sndio

@sarcasticadmin sarcasticadmin Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt sndio specific to darwin and openbsd? https://github.com/wb2osz/direwolf/blob/a231971a652bfb574a4bae9a5d875fbce53d2267/CMakeLists.txt#L396C1-L396C7

]
++ lib.optionals stdenv.hostPlatform.isLinux [
alsa-lib
avahi

@sarcasticadmin sarcasticadmin Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avahi seems optional as well https://github.com/wb2osz/direwolf/blob/a231971a652bfb574a4bae9a5d875fbce53d2267/CMakeLists.txt#L389

udev
libcap
libgpiod

@sarcasticadmin sarcasticadmin Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpiod seems optional? https://github.com/wb2osz/direwolf/blob/a231971a652bfb574a4bae9a5d875fbce53d2267/CMakeLists.txt#L347

Seems like it could be being a boolean and defaulted to false

]
++ lib.optionals gpsdSupport [ gpsd ]
++ lib.optionals hamlibSupport [ hamlib ]
++ lib.optionals extraScripts [
python3
perl
espeak
];
nativeInstallCheckInputs = [ versionCheckHook ];

preConfigure = lib.optionals (!extraScripts) ''
Expand Down
Loading