feat(mail): open recognized HWPX text from email attachments - #1406
feat(mail): open recognized HWPX text from email attachments#1406seonghobae wants to merge 20 commits into
Conversation
List the current email's attachments with the same opaque asset_key as the Data preview contract so a buyer can read ordered HWPX paragraphs from mail without treating missing text as empty content. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. Important Approval pendingCodeRabbit has no unresolved comments, but it skipped the latest review. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
📝 WalkthroughWalkthroughEmail detail and thread responses now expose opaque attachment references. The dashboard renders selected attachments through the repository preview endpoint and handles HWPX recognition states without exposing internal identifiers. ChangesMail attachment preview
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant EmailDetail
participant MailAttachmentPreview
participant RepositoryAssetPreviewPanel
User->>EmailDetail: select email
EmailDetail->>MailAttachmentPreview: provide attachment references
MailAttachmentPreview->>RepositoryAssetPreviewPanel: request preview by asset_key
RepositoryAssetPreviewPanel-->>MailAttachmentPreview: return preview state and paragraphs
MailAttachmentPreview-->>User: display selected attachment
Merge Risk: ⚪ Minimal · up to This PR adds recognized HWPX attachment previews to email while preserving existing preview behavior and unavailable/pending states. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR governance metadata gate is not ready for
|
Wire the inherited 다시 확인 control to re-fetch the same opaque mail attachment preview so the stacked parent refresh stays reachable. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Bring Draft #1407 onto independently resolved live #1406 b83a0da. Previous parent 304d5af is stale. Keep #1404/#1406 pending 다시 확인 refresh and mail reachability together with the fail-closed Inkspan edit handoff. No rebase, squash, or force-push. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
@coderabbitai review The rolling-hour window from #1404 |
|
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
opencode-agent
Bot
added
priority: medium
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ff9fc7a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| file_name = _safe_email_display_text(getattr(attachment, "filename", None)) | ||
| refs.append( | ||
| EmailAttachmentRef( | ||
| asset_key=_opaque_asset_key(email, attachment), |
There was a problem hiding this comment.
When one email contains two attachments with the same filename—which the attachment schema permits—both references receive the same key because _opaque_asset_key hashes only the owner, message ID, and filename. MailAttachmentPreview subsequently uses that key for React identity, selection, and caching, while the preview endpoint returns the first matching row, so clicking either attachment can display the wrong document. Include an immutable attachment-specific value in the key and lookup, then add a duplicate-filename case to backend/tests/test_email_attachment_preview.py.
AGENTS.md reference: AGENTS.md:L449-L454
Useful? React with 👍 / 👎.
seonghobae
added
the
enhancement
ChatGPT Codex Connector
2 participants
Current authority — 2026-09-10
This mail HWPX preview slice remains valid product work, but it is Draft / not merge-ready.
develop@042b0c70531b229af3acbd0421a2f23098d848b3a1a3d461b2863b5fae0537ff8c84ac28d8c75665edd3134a197fe819df366b469a2a4a1c5b27b4f7Parent adoption
40594758c1f1791a1d679fb0ee0da0d1c8b2cf06non-force merged current #1404 into this branch;cc7d2cefd41aff24bac1a1a94d3a0205984816c1then exact-adopted current parent blobs left stale by the first merge. The child therefore inherits #1404 preview authority without force-push, destructive rebase, or parent-source rollback.Retained child repairs
63fd00a9382c47f8e530a8c47b43f2988f80f9f7rejectsemail_attachments.contentprojection in mail detail/thread. Fix6d3bcc5afe0e6e0ccea9c03e03f2e7496f81947ausesselectinload(...).load_only(Attachment.filename, Attachment.parser_key, raiseload=True).7615754fb9a49b3378db6d73f5093e9f53660e19deletes seeded attachment then email rows before engine disposal.bc24bf682ff6998610db39c90dc644cfeb8baad5and fix298bbba1fd8f3b4dcb9cdc7ac50bb6f2dd3e472euse per-asset request sequencing so stale completion cannot overwrite a newer recognized state.501d019e1ae0efde3b5df333047fda4fdd88b971exercises the real HMAC bearer verifier and rejects public identity headers alone; exactedd3134...adds browser evidence requiringnaruon_sessionon mail-detail and attachment-preview requests.Corrected parent prerequisite map
The previous body repeated #1404's stale statement that #1345 had to be adopted as the workspace-document organization prerequisite. That is no longer the live owner map.
Fresh #1345/#1417/#1645 succession audit establishes:
489bcbeaf131da123551a187228862b0e47ad549by_document_organization_filter, current data-action/quality-surface regressions, and real PostgreSQL legacy-null-organization evidence;Accordingly #1406 inherits the same requirement through its parent: do not restack or copy #1345. Wait for #1404 to reconcile its temporary document-scope overlap against the protected #1417 result, then ordinary-restack this child on the resulting #1404 head while retaining only child-owned mail-preview behavior.
Remaining live finding
Duplicate filename attachment identity remains unresolved on the parent/child boundary. Two MIME parts with the same filename can receive the same opaque key because attachment identity is not in the digest. This must be repaired once in canonical parent #1404 and inherited here; #1406 must not invent competing key semantics.
Parent #1404 also retains the attachment workspace-identity gap and preview retry/staleness findings. This child must not bypass them.
Evidence and merge boundary
This is a non-default stacked branch. Current exact-head backend/frontend/PostgreSQL/browser/signed-session evidence and qualifying independent review must apply to the final parent topology; predecessor checks do not transfer. Do not manufacture a dummy commit or broaden workflow admission solely to create a receipt.
Keep Draft until #1404 and its canonical prerequisites are healthy, the duplicate-key owner finding is fixed and inherited, exact-head required execution is terminal-success, and qualifying post-last-push independent approval applies.
No force push, destructive rebase, self-approval, dummy requeue, stale-evidence transfer, bypass, or gate weakening.