-
Notifications
You must be signed in to change notification settings - Fork 1
feat(mail): open recognized HWPX text from email attachments #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seonghobae
wants to merge
20
commits into
cursor/hwpx-recognized-text-preview-b246
Choose a base branch
from
cursor/mail-hwpx-attachment-preview-7b5e
base: cursor/hwpx-recognized-text-preview-b246
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 4 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
304d5af
feat(mail): open recognized HWPX text from email attachments
cursoragent d2e201c
merge: retarget #1406 onto live #1404 head
cursoragent b83a0da
fix(mail): reuse live #1404 pending preview refresh
cursoragent 1ff9fc7
merge(stack): inherit repaired HWPX preview head
seonghobae 6878fc4
fix(docs): restore canonical AGENTS ownership
seonghobae 4c03dec
merge(stack): inherit current HWPX preview parent
seonghobae 26895b6
merge(stack): inherit current Data preview parent
seonghobae 55f489a
docs(mail): restore mail preview traceability
seonghobae 0edb98f
merge(mail): restore preview E2E fixture delta
seonghobae 4059475
merge(mail): adopt current HWPX preview parent
seonghobae cc7d2ce
fix(mail): preserve current preview parent tree
seonghobae 63fd00a
test(mail): forbid attachment-body loads in detail and thread
seonghobae 6d3bcc5
fix(mail): load attachment metadata without bodies
seonghobae 7615754
test(mail): clean PostgreSQL preview smoke rows
seonghobae bc24bf6
test(mail): keep latest attachment preview response
seonghobae 298bbba
fix(mail): ignore stale attachment preview responses
seonghobae b0ba575
chore(mail): preserve preview source newline
seonghobae c5fde35
chore(mail): preserve preview test newline
seonghobae 501d019
test(mail): exercise real signed attachment session
seonghobae edd3134
test(mail): verify cookie-backed attachment preview path
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When one email contains two attachments with the same filename—which the attachment schema permits—both references receive the same key because
_opaque_asset_keyhashes only the owner, message ID, and filename.MailAttachmentPreviewsubsequently uses that key for React identity, selection, and caching, while the preview endpoint returns the first matching row, so clicking either attachment can display the wrong document. Include an immutable attachment-specific value in the key and lookup, then add a duplicate-filename case tobackend/tests/test_email_attachment_preview.py.AGENTS.md reference: AGENTS.md:L449-L454
Useful? React with 👍 / 👎.