fix(e2e): establish the organisation baseline instead of inheriting it - #1509
rubenvdlinde wants to merge 1 commit into
Conversation
`development` has been red on this one test since the ADR-111 demo-data
step landed (304 passed, 1 failed).
The test asserts a FLIP: organisation.done goes false -> true when the
details are saved. It read the "false" end off whatever the instance
happened to hold:
const before = await api(page, 'GET', `${APP}/api/setup/status`)
expect(before.json?.steps?.organisation?.done).toBe(false)
That is no longer empty. The `demo-data` setup step seeds an organisation,
so on any instance where demo data ran, `receipt_company_name` is already
set and the step is already done — expected false, received true.
Clearing the three keys first costs one request and makes the flip
attributable to this test rather than to which specs happened to run
before it. The `finally` block already restores them, so the test remains
a no-op for its neighbours.
The precondition also gains a message. `Expected: false / Received: true`
on a bare boolean says nothing about which of the two possible causes it
is — the step not resetting, or the save not landing.
Supersedes #1503, which fixed the same failure by seeding the value the
test then asserted was absent; that inverts the flip rather than
establishing it, and the PR went stale and conflicted.
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 645/645 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | 🚨 NO VERDICT — enabled but never ran | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-28 18:51 UTC
Download the full PDF report from the workflow artifacts.
|
Superseded — Merging Development's version: // Precondition: unset, so the flip below is caused by this test.
//
// ESTABLISHED, not asserted. ... Since the demo-data step began seeding on
// install, `receipt_company_name` is populated before this spec runs ...
await api(page, 'POST', `${APP}/api/setup/config`, { receipt_company_name: '', ... })Same diagnosis, same remedy, landed independently while this was open. The E2E failure this was opened for is therefore already addressed on |
fix(e2e): establish the organisation baseline instead of inheriting it
developmenthas been red on this one test since the ADR-111 demo-datastep landed (304 passed, 1 failed).
The test asserts a FLIP: organisation.done goes false -> true when the
details are saved. It read the "false" end off whatever the instance
happened to hold:
That is no longer empty. The
demo-datasetup step seeds an organisation,so on any instance where demo data ran,
receipt_company_nameis alreadyset and the step is already done — expected false, received true.
Clearing the three keys first costs one request and makes the flip
attributable to this test rather than to which specs happened to run
before it. The
finallyblock already restores them, so the test remainsa no-op for its neighbours.
The precondition also gains a message.
Expected: false / Received: trueon a bare boolean says nothing about which of the two possible causes it
is — the step not resetting, or the save not landing.
Supersedes #1503, which fixed the same failure by seeding the value the
test then asserted was absent; that inverts the flip rather than
establishing it, and the PR went stale and conflicted.