Skip to content

fix(e2e): establish the organisation baseline instead of inheriting it #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubenvdlinde wants to merge 1 commit into from
Closed

fix(e2e): establish the organisation baseline instead of inheriting it #1509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions tests/e2e/spec-coverage/first-time-setup.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,27 @@ test.describe('First-time setup contract', () => {
}) => {
await openApp(page)

// Precondition: unset, so the flip below is caused by this test.
// ESTABLISH the precondition, do not inherit it. This test asserts a
// FLIP from not-done to done, which only means anything from a known
// starting point — and the starting point is no longer empty: the
// ADR-111 `demo-data` setup step seeds an organisation, so on a CI
// instance where demo data ran, `receipt_company_name` is already set
// and `organisation.done` is already true.
//
// Reading the baseline off whatever the instance happens to hold made
// this test's verdict depend on which other specs ran first. Clearing
// the keys here costs one request and makes the flip attributable to
// this test alone.
await api(page, 'POST', `${APP}/api/setup/config`, {
receipt_company_name: '',
receipt_company_vat: '',
receipt_company_kvk: '',
})
const before = await api(page, 'GET', `${APP}/api/setup/status`)
expect(before.json?.steps?.organisation?.done).toBe(false)
expect(
before.json?.steps?.organisation?.done,
'clearing receipt_company_name did not reset the organisation step, so the flip asserted below would prove nothing',
).toBe(false)

try {
const saved = await api(page, 'POST', `${APP}/api/setup/config`, {
Expand Down
Loading