fix(e2e): the cleanup must restore the seed, not clear it

[rubenvdlinde]

Follow-up to #1509 (bba1a91), which fixed the precondition half of this test. This is the other half, still live on development.

The cleanup does the opposite of what it says

} finally {
    // Leave the instance exactly as found — other specs share it.
    receipt_company_name: '',

ci-seed.sh step 3b sets that key precisely so no optional step is outstanding, and its own error message states the consequence:

An unmet optional step makes CnAppRoot cover the shell with the wizard in every fresh browser context.

So this finally hands that modal mask to every spec that runs afterwards — while asserting done === false, i.e. asserting that it left the instance in the bad state.

The evidence it is already costing something

In the run this test last failed in, dashboard.spec.ts was flaky three ways:

• renders the dashboard page for the default route
• every required KPI and chart widget is rendered
• the quick-create actions are offered

Three specs about rendering the shell, intermittently failing, in a suite where one test deliberately leaves a modal able to cover the shell. That is consistent enough to act on, and cheap to act on.

The change

Restore the seeded value rather than clearing it, and assert done === true — the state ci-seed established.

The literal, and why it is one

There is no GET for the setup config — only /api/setup/status, which returns booleans — so the original value cannot be read back and restored dynamically. 'CI Test Organisation' is the string ci-seed.sh writes, and the comment says so: if the seed changes, this changes with it. A documented coupling is better than a cleanup that silently re-opens the wizard.

Scope

I did not touch the flaky dashboard specs. If this diagnosis is right they settle on their own; if they do not, they are a real defect and deserve investigating as one rather than being pre-emptively patched.

Verified: node --experimental-strip-types --check clean; built on current development (so it carries #1509's precondition fix rather than conflicting with it); pushed file byte-identical.

[github-actions]

Quality Report — ConductionNL/pipelinq @ 05b64dc

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue-demi		✅
test-l10n		✅
format		✅
check-schema-l10n		✅
check-l10n-js		✅
composer			✅	✅ 106/106
npm			✅	✅ 645/645
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					✅
Newman					✅
Playwright					🚨 NO VERDICT — enabled but never ran
Hydra gates					✅

---

Quality workflow — 2026-08-28 19:43 UTC

Download the full PDF report from the workflow artifacts.