fix(installation): correct raw source URLs - #836
Merged
Merged
Conversation
Point installer, loader, and checksum references at the live public paths in z-shell/src. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Deploying zsh with
|
| Latest commit: |
7811956
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fdf9796b.zsh.pages.dev |
| Branch Preview URL: | https://hotfix-833.zsh.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the installation documentation to point at the correct GitHub raw URLs after z-shell/src moved public installer artifacts from lib/ to public/, restoring broken production links and unblocking the next → main promotion workflow.
Changes:
- Update the installer raw URL to
public/sh/install.sh. - Update the loader raw URL to
public/zsh/init.zsh. - Update the checksum reference to
public/checksum.txt.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Blocked by the required Trunk baseline comparison, not by the hotfix content. Evidence:
No merge was attempted. I am not adding a temporary ignore, weakening the checker, or using an administrator/API bypass. A normal merge requires either a Trunk baseline-comparison fix or restoration of the old URLs by |
This was referenced Aug 14, 2026
Convert Lychee JSON failures into Trunk issues so pull-request baseline comparison can distinguish fixed links from tool crashes without suppressing link validation. Canonicalize sandbox symlinks and cover them in tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep Lychee pinned as the Trunk tool while allowing the adapter to invoke the runner-provided Node runtime in isolated linter sandboxes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair three broken production documentation links after
z-shell/srcmoved public installer artifacts fromlib/topublic/:public/checksum.txtpublic/sh/install.shpublic/zsh/init.zshAlso make the custom Lychee integration emit structured Trunk issues from Lychee 0.23 JSON. This preserves link enforcement while allowing Trunk’s intended pull-request baseline comparison to recognize that the hotfix removes the three base findings instead of treating Lychee exit code 2 as a tool crash. The adapter handles Trunk’s sandbox symlink invocation and has regression coverage.
Validation
pnpm validate:frontmatter docs/getting_started/01_installation.mdxpnpm build:enpnpm lintnode --test scripts/trunk-lychee.test.mjspnpm exec trunk check --upstream origin/main --no-fixgit diff --checkThis is a production-link hotfix and unblocks the normal
next→mainpromotion in #833.