chore(repo): sync production hotfix into next - #837
Merged
Conversation
Point installer, loader, and checksum references at the live public paths in z-shell/src. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Convert Lychee JSON failures into Trunk issues so pull-request baseline comparison can distinguish fixed links from tool crashes without suppressing link validation. Canonicalize sandbox symlinks and cover them in tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep Lychee pinned as the Trunk tool while allowing the adapter to invoke the runner-provided Node runtime in isolated linter sandboxes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
fix(installation): correct raw source URLs
Merge the verified production link and structured Lychee baseline fixes from main so the integration branch and release promotion share the same validated state. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Deploying zsh with
|
| Latest commit: |
525136d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://437d0e6a.zsh.pages.dev |
| Branch Preview URL: | https://feature-833-sync.zsh.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs a verified production hotfix from main back into next, ensuring the development branch includes the latest documentation link corrections and the updated Lychee-to-Trunk integration needed for reliable link-check baselines.
Changes:
- Correct remaining raw GitHub URL references from
lib/→public/in installation docs. - Add a
scripts/trunk-lychee.mjswrapper that converts Lychee JSON output into structured Trunk issues with appropriate exit codes. - Add regression tests covering JSON formatting and Trunk’s symlink-sandbox invocation behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/trunk-lychee.test.mjs | Adds Node test coverage for Lychee JSON → Trunk issue formatting and symlink invocation. |
| scripts/trunk-lychee.mjs | Introduces the Lychee adapter CLI and formatter used by Trunk for link checking. |
| docs/getting_started/01_installation.mdx | Updates raw source URLs for loader and checksum to point at public/. |
| .trunk/trunk.yaml | Switches the Lychee linter to run via the Node adapter and parse structured output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| return issues; | ||
| } | ||
|
|
||
| for (const [path, errors] of Object.entries(errorMap).sort(([left], [right]) => left.localeCompare(right))) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronize verified production hotfix #836 into
nextbefore resuming release promotion #833.This brings in:
lib/→public/URL corrections (the installer correction was already present onnext)The signed merge commit has exact parents
c9def58b6bc60d74361b323ae25a7efec20164fd(next) andb63ea8e319b30dc392d1f7362c874c992e0f3fd6(main). All incoming commits are GitHub-verified.Validation
pnpm install --frozen-lockfilepnpm exec trunk check --ignore-git-statenode --test scripts/trunk-lychee.test.mjspnpm buildpnpm wrangler:typecheckgit diff --checkUnblocks #833.