Skip to content

Fix PHP 8.4 Deprecations #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PatelUtkarsh merged 2 commits into from
Jul 13, 2026
+3 −3
Merged

Fix PHP 8.4 Deprecations #1923

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0067ebc
Fix PHP 8.4 Deprecations
TheVitik Jul 9, 2026
136d5f9
Fix phpcs issues
TheVitik Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/class-cli.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ private function csv_format( $records ) {
$output = fopen( 'php://output', 'w' ); // @codingStandardsIgnoreLine Clever output for WP CLI using php://output

foreach ( $records as $line ) {
fputcsv( $output, $line );
fputcsv( $output, $line, ',', '"', '\\' );
}

fclose( $output ); // @codingStandardsIgnoreLine
Expand Down
4 changes: 2 additions & 2 deletions exporters/class-exporter-csv.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ public function output_file( $data, $columns ) {
ob_start();

$csv = fopen( 'php://output', 'w' );
fputcsv( $csv, array_values( $columns ) );
fputcsv( $csv, array_values( $columns ), ',', '"', '\\' );

foreach ( $data as $row ) {
fputcsv( $csv, $row );
fputcsv( $csv, $row, ',', '"', '\\' );
}
fclose( $csv ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_system_operations_fclose

Expand Down