Fix PHP 8.4 Deprecations#1923
Merged
Merged
Conversation
Contributor
Author
|
Hi @PatelUtkarsh , thank you for the review. Could you please check again? When is it possible to release these changes? |
Member
|
Hello @TheVitik, We can include it in next release; however next release isn't planned yet; I will let you know as soon as I confirm with team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes PHP 8.4 deprecation warnings related to
fputcsv().Starting with PHP 8.4, calling
fputcsv()without explicitly passing the$escapeparameter triggers the following deprecation warning:Changes
fputcsv()where the$escapeparameter was omitted.'\\') to preserve the existing behavior and eliminate the deprecation warning.Example:
Impact
This change is fully backward compatible and prepares the codebase for PHP 8.4 by removing the deprecation warnings without changing the existing CSV output behavior.