Repository navigation
fix: report unknown parents instead of panicking - #64
Open
matthargett wants to merge 1 commit into
Open
matthargett wants to merge 1 commit into
matthargett wants to merge 1 commit into
Conversation
An interface or dictionary that inherits from a type absent from the input (declared by another specification) made `handle_resource_inheritance` and `handle_record_inheritance` unwrap a missing lookup and panic. The lookups now follow `HandleUnsupported`: `Bail` returns an error naming the child and the missing parent, `Skip` and `Warn` leave the child without the inherited members and without the `as-*` conversions for that parent. Fixes wasi-gfx#55.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An interface or dictionary that inherits from a type absent from the input, as happens whenever one specification's IDL is converted on its own, made
handle_resource_inheritanceandhandle_record_inheritanceunwrap a missing lookup and panic. The lookup now followsHandleUnsupported:Bailreturns an error naming the child and the missing parent, andSkip/Warnleave the child without the inherited members and without theas-*conversion for that parent. Theunknown-parentfixture covers resource and record inheritance underWarn, and a test asserts that the defaultBailmode returns an error.Ran into this while making a WebXR on WebGPU-derived WASI module
Fixes #55