Repository navigation
fix: report unknown parents instead of panicking - #1
Open
matthargett wants to merge 1 commit into
Open
matthargett wants to merge 1 commit into
matthargett wants to merge 1 commit into
Conversation
An interface or dictionary that inherits from a type absent from the input (declared by another specification) made `handle_resource_inheritance` and `handle_record_inheritance` unwrap a missing lookup and panic. The lookups now follow `HandleUnsupported`: `Bail` returns an error naming the child and the missing parent, `Skip` and `Warn` leave the child without the inherited members and without the `as-*` conversions for that parent. Fixes wasi-gfx#55.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staged for upstream wasi-gfx/webidl2wit (bug fix, no prior issue needed per CONTRIBUTING; closes wasi-gfx#55).
An interface or dictionary that inherits from a type absent from the input, as happens whenever one specification's IDL is converted without the specifications it builds on, made
handle_resource_inheritanceandhandle_record_inheritanceunwrap a missing lookup and panic.The lookups now follow
HandleUnsupported:Bailreturns an error naming the child and the missing parent, sowebidl_to_witfails instead of aborting the process;SkipandWarnleave the child without the inherited members and without theas-*conversions for that parent.Tests:
unknown-parentfixture underWarn+Both, and an assertion that the defaultBailmode returnsErr.cargo testandcargo fmt --checkpass.Submitted upstream as wasi-gfx#64.