Skip to content

Unskip .ts subcommand lookup test now that node 20 is EOL #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damienmeur wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Unskip .ts subcommand lookup test now that node 20 is EOL #2552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/command.executableSubcommand.lookup.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@ describe('executable subcommand lookup ', () => {
},
);

// This test currently fails on Node 20 when run as ESM because Node does not execute .ts files as JavaScript by default.
test.skip('when subcommand suffix is .ts then lookup succeeds', async () => {
test('when subcommand suffix is .ts then lookup succeeds', async () => {
// We support looking for ts files for ts-node in particular, but don't need to test ts-node itself.
// The subcommand is both plain JavaScript code for this test.
const binLinkTs = path.join(
Expand Down
Loading