Skip to content

Unskip .ts subcommand lookup test now that node 20 is EOL#2552

Open
damienmeur wants to merge 1 commit into
tj:developfrom
damienmeur:chore/unskip-lookup-test
Open

Unskip .ts subcommand lookup test now that node 20 is EOL#2552
damienmeur wants to merge 1 commit into
tj:developfrom
damienmeur:chore/unskip-lookup-test

Conversation

@damienmeur

Copy link
Copy Markdown

Problem

The .ts executable-subcommand lookup test was skipped in the ESM-only migration (#2464) because it failed on Node 20, which does not run .ts files.

Solution

Node 20 is now EOL and was dropped from the test matrix in #2520, and all current matrix versions (22.x, 24.x, 26.x) run the plain-JS .ts fixture via default type stripping. This un-skips the test and removes the stale comment; it passes locally on Node 22.22.2, 24.15.0, and 26.3.0.

ChangeLog

Test-only change, no CHANGELOG entry needed.

@shadowspawn

Copy link
Copy Markdown
Collaborator

This looks simple and tidy but...

To be clear: is this Pull Request entirely AI/LLM generated?

@damienmeur

Copy link
Copy Markdown
Author

Fair question. The change itself is a one-liner (un-skip + drop a stale comment), so there wasn't much to generate — but yes, the PR text was AI-drafted and I used AI tooling to prepare it.

The backstory: I'm building a code-analysis tool (statistical, not an LLM), and commander has been one of the real-world repos I benchmark it against. It flagged this test as skipped with a stale reason. Commander's history has been genuinely useful to me, so fixing the things it surfaces felt like a fair way to give something back.

I did verify before filing: the un-skipped test passes 14/14 locally on Node 22.22.2, 24.15.0 and 26.3.0 — the current CI matrix — and Node 20 was dropped as EOL in #2520. Happy to close if you'd rather not take it.

@shadowspawn

Copy link
Copy Markdown
Collaborator

I regularly ask this question because the human effort can be very mismatched with AI generated Pull Requests and a human reviewer. If heavy AI, the AI may be out of credit or disconnected by the time I ask questions if needed, so I limit my effort.

Thanks for the back story. Glad history proving useful. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants