fix(tbtc/signer): reject unknown admission policy fields#4161
Merged
mswilkison merged 2 commits intoJul 15, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 15, 2026
mswilkison
changed the base branch from
fix/signer-persistence-retry-followups-2026-07-14
to
extraction/frost-signer-mirror-2026-05-26
July 15, 2026 11:01
mswilkison
added a commit
that referenced
this pull request
Jul 15, 2026
## Stack 1 of 3. Base: `extraction/frost-signer-mirror-2026-05-26` (#4005). Next: #4161. ## Summary - Normalize one-component signer state paths to `.` for directory creation, fsync, and corrupt-backup enumeration. - Make completed canary rollback retries true no-ops for rollout state, config version, metrics, and promotion evidence. - Repair uncertain post-rename directory durability on a restarted rollback retry without rewriting the state file; keep fresh missing-state no-ops side-effect free. ## Review findings addressed - P1: bare state paths used an empty parent for directory operations. - P2: completed canary rollback retries were not idempotent. ## Validation - `cargo test --locked --manifest-path pkg/tbtc/signer/Cargo.toml` on this branch tip: 270 library tests passed, 1 ignored; 28 admission-checker tests passed; 1 integration test passed. - Fault-injection regressions cover pre/post-rename behavior, restarted retry repair, and no state rewrite on idempotent retry.
mswilkison
merged commit Jul 15, 2026
eb1277b
into
extraction/frost-signer-mirror-2026-05-26
20 checks passed
mswilkison
added a commit
that referenced
this pull request
Jul 15, 2026
## Stack 3 of 3. Parent: #4161. ## Summary - Track each live interactive signing member from its last accepted activity using monotonic `Instant` state instead of wall-clock Open time. - Refresh activity for exact Open retries, accepted Round1 calls, and retry-preserving Round2 failures; rejected traffic does not extend lifetime. - Add a forward-only test clock and regressions for active-at-boundary attempts, idle siblings, invalid requests, retry-preserving failures, expiry, and reset behavior. ## Review finding addressed - P2: interactive inactivity TTL was measured from Open and could sweep an attempt used moments earlier. ## Lifecycle invariant Only accepted or retry-preserving member activity extends the TTL; successful terminal operations and post-replacement failures still retire the nonce handle. ## Validation - `cargo test --locked --manifest-path pkg/tbtc/signer/Cargo.toml`: 273 library tests passed, 1 ignored; 30 admission-checker tests passed; 1 integration test passed. - `cargo check --locked --manifest-path pkg/tbtc/signer/Cargo.toml --all-targets`. - `cargo clippy --locked --manifest-path pkg/tbtc/signer/Cargo.toml --all-targets -- -D warnings`. - `cargo fmt --manifest-path pkg/tbtc/signer/Cargo.toml -- --check` and `git diff --check`. - `pkg/tbtc/signer/scripts/run_phase5_chaos_suite.sh`: all 6 fault-injection scenarios passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
2 of 3. Parent: #4160. Next: #4162.
Summary
AdmissionPolicyV1.Review finding addressed
Security invariant
A policy field that the checker does not recognize cannot silently alter or weaken admission behavior.
Validation
cargo test --locked --manifest-path pkg/tbtc/signer/Cargo.tomlon this branch tip: 270 library tests passed, 1 ignored; 30 admission-checker tests passed; 1 integration test passed.max_operator_per_providerfield and accepts the shipped policy sample.