fix(tbtc/signer): harden state-path and rollback durability#4160
Merged
mswilkison merged 1 commit intoJul 15, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mswilkison
merged commit 72897cb
into
extraction/frost-signer-mirror-2026-05-26
20 checks passed
mswilkison
added a commit
that referenced
this pull request
Jul 15, 2026
## Stack 2 of 3. Parent: #4160. Next: #4162. ## Summary - Reject unknown top-level fields when deserializing `AdmissionPolicyV1`. - Keep supported policy files compatible while turning misspelled security controls into explicit input errors instead of omitted limits. - Add a malicious typo regression and a supported-field positive control. ## Review finding addressed - P2: unknown admission-policy fields could silently disable enforcement and fail open. ## Security invariant A policy field that the checker does not recognize cannot silently alter or weaken admission behavior. ## Validation - `cargo test --locked --manifest-path pkg/tbtc/signer/Cargo.toml` on this branch tip: 270 library tests passed, 1 ignored; 30 admission-checker tests passed; 1 integration test passed. - The real checker rejects a misspelled `max_operator_per_provider` field and accepts the shipped policy sample.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
1 of 3. Base:
extraction/frost-signer-mirror-2026-05-26(#4005). Next: #4161.Summary
.for directory creation, fsync, and corrupt-backup enumeration.Review findings addressed
Validation
cargo test --locked --manifest-path pkg/tbtc/signer/Cargo.tomlon this branch tip: 270 library tests passed, 1 ignored; 28 admission-checker tests passed; 1 integration test passed.