fix(tbtc): complete Taproot discovery and fee handling#4146
Merged
mswilkison merged 1 commit intoJul 12, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 11, 2026
mswilkison
force-pushed
the
fix/pr3866-registry-review
branch
from
July 11, 2026 20:03
3898afd to
d0401b1
Compare
mswilkison
force-pushed
the
fix/pr3866-taproot-review
branch
3 times, most recently
from
July 12, 2026 20:12
fce3a0c to
d6497bf
Compare
mswilkison
force-pushed
the
fix/pr3866-registry-review
branch
from
July 12, 2026 20:12
d0401b1 to
b674361
Compare
mswilkison
force-pushed
the
fix/pr3866-registry-review
branch
from
July 12, 2026 22:01
b674361 to
1294939
Compare
mswilkison
force-pushed
the
fix/pr3866-taproot-review
branch
from
July 12, 2026 22:01
d6497bf to
014b43b
Compare
mswilkison
added a commit
that referenced
this pull request
Jul 12, 2026
Stack 1 of 3 on top of #3866. Followed by #4145 and #4146. Addresses the FROST DKG configuration and coordinator findings from the latest review: - load `groupSize`, `activeThreshold`, and `groupThreshold` from `FrostDkgValidator` independently of the legacy ECDSA validator - use the FROST parameters for DKG execution, result signing, readiness, signer registration, recovery lookback, wallet signing, and inactivity executors - replace eager seven-day FROST event deduplication with atomic in-progress leases that are released after transient failures and completed only after work is handled or safely scheduled - when a stale DkgStarted replay resolves a newer event, complete the stale lease and acquire a fresh lease for the newer seed before membership or DKG execution - guard nil native DKG parameters and treat build-level native unavailability as terminal for the current process while keeping runtime-changeable gates retryable - stop result approval immediately when the parent context is canceled Startup now intentionally fails if `FrostWalletRegistry` is enabled without a configured `FrostDkgValidator`, because the node cannot safely infer the independent FROST thresholds. Verification: - `go test ./pkg/tbtc ./pkg/chain/ethereum` - focused default and `frost_native` coordinator/parameter tests - focused race tests and `go vet` - stale-to-latest seed regressions covering concurrent, completed, and transient-failure cases The next stack layer, #4145, routes heartbeat, inactivity, and closure handling through the wallet's scheme-specific registry.
mswilkison
added a commit
that referenced
this pull request
Jul 12, 2026
## Stack 2 of 3. Depends on #4144, is followed by #4146, and targets `fix/pr3866-dkg-review`. ## What changed - route FROST inactivity claims through FrostWalletRegistry and FrostSortitionPool, including the FROST claim hash and operator IDs - keep legacy heartbeat stake and registration checks bound to the ECDSA registry during dual-stack migration - subscribe to and recover recent FROST wallet-closure and inactivity-claim events through cancellation-aware delivery; in-flight log filters stop on unsubscribe - confirm wallet closure and remove signer material against the wallet's signing scheme - make closure deduplication scheme-scoped, retryable after failures, and safe when a replay arrives during active handling - remove the obsolete eager ECDSA-only closure helper and align local-chain FROST registration behavior with production ## Verification - `go test ./pkg/tbtc ./pkg/chain/ethereum` - `go test -tags=frost_native ./pkg/tbtc ./pkg/chain/ethereum` - focused `-race` tests for wallet-closure deduplication and FROST inactivity event delivery
Base automatically changed from
fix/pr3866-registry-review
to
feat/frost-schnorr-migration-scaffold
July 12, 2026 22:27
mswilkison
merged commit Jul 12, 2026
0b0f663
into
feat/frost-schnorr-migration-scaffold
35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
3 of 3. Depends on #4145 and targets
fix/pr3866-registry-review.What changed
Verification
go test ./pkg/bitcoin ./pkg/maintainer/spv ./pkg/tbtcpg ./pkg/tbtc ./pkg/chain/ethereumgo test -tags=frost_native ./pkg/tbtc ./pkg/chain/ethereum