fix(tbtc): separate FROST parameters and retry DKG events#4144
Merged
mswilkison merged 1 commit intoJul 12, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mswilkison
force-pushed
the
fix/pr3866-dkg-review
branch
from
52b8ee5 to
5abaa92
Compare
mswilkison
merged commit a3d96ee
into
feat/frost-schnorr-migration-scaffold
18 checks passed
mswilkison
added a commit
that referenced
this pull request
Jul 12, 2026
## Stack 2 of 3. Depends on #4144, is followed by #4146, and targets `fix/pr3866-dkg-review`. ## What changed - route FROST inactivity claims through FrostWalletRegistry and FrostSortitionPool, including the FROST claim hash and operator IDs - keep legacy heartbeat stake and registration checks bound to the ECDSA registry during dual-stack migration - subscribe to and recover recent FROST wallet-closure and inactivity-claim events through cancellation-aware delivery; in-flight log filters stop on unsubscribe - confirm wallet closure and remove signer material against the wallet's signing scheme - make closure deduplication scheme-scoped, retryable after failures, and safe when a replay arrives during active handling - remove the obsolete eager ECDSA-only closure helper and align local-chain FROST registration behavior with production ## Verification - `go test ./pkg/tbtc ./pkg/chain/ethereum` - `go test -tags=frost_native ./pkg/tbtc ./pkg/chain/ethereum` - focused `-race` tests for wallet-closure deduplication and FROST inactivity event delivery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 1 of 3 on top of #3866. Followed by #4145 and #4146.
Addresses the FROST DKG configuration and coordinator findings from the latest review:
groupSize,activeThreshold, andgroupThresholdfromFrostDkgValidatorindependently of the legacy ECDSA validatorStartup now intentionally fails if
FrostWalletRegistryis enabled without a configuredFrostDkgValidator, because the node cannot safely infer the independent FROST thresholds.Verification:
go test ./pkg/tbtc ./pkg/chain/ethereumfrost_nativecoordinator/parameter testsgo vetThe next stack layer, #4145, routes heartbeat, inactivity, and closure handling through the wallet's scheme-specific registry.