-
Notifications
You must be signed in to change notification settings - Fork 1k
Fixes #39463 - Handle host bulk action errors consistently #11045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sbernhard
wants to merge
1
commit into
theforeman:develop
Choose a base branch
from
ATIX-AG:fix_39463
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
142 changes: 142 additions & 0 deletions
142
webpack/assets/javascripts/react_app/components/HostsIndex/BulkActions/helpers.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| import { buildBulkRequestBody, bulkErrorToastParams } from './helpers'; | ||
|
|
||
| jest.mock('../../../common/I18n'); | ||
|
|
||
| describe('BulkActions helpers', () => { | ||
| describe('bulkErrorToastParams', () => { | ||
| it('uses API error details from the response', () => { | ||
| const toast = bulkErrorToastParams( | ||
| { | ||
| response: { | ||
| data: { | ||
| error: { | ||
| message: 'Some hosts failed', | ||
| failed_host_ids: [1, 2], | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| 'BULK_ACTION_KEY' | ||
| ); | ||
|
|
||
| expect(toast).toMatchObject({ | ||
| type: 'danger', | ||
| message: 'Some hosts failed', | ||
| }); | ||
| expect(toast.link.children).toBe('Failed hosts'); | ||
| expect(toast.link.href).toContain('/new/hosts'); | ||
| expect(toast.link.href).toContain('search='); | ||
| }); | ||
|
|
||
| it('uses the error message when no response exists', () => { | ||
| const toast = bulkErrorToastParams( | ||
| { message: 'Network Error' }, | ||
| 'BULK_ACTION_KEY' | ||
| ); | ||
|
|
||
| expect(toast).toMatchObject({ | ||
| type: 'danger', | ||
| message: 'Network Error', | ||
| }); | ||
| expect(toast.link).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('uses a response error string as the message', () => { | ||
| const toast = bulkErrorToastParams( | ||
| { | ||
| response: { | ||
| data: { | ||
| error: 'Bulk action failed', | ||
| }, | ||
| }, | ||
| }, | ||
| 'BULK_ACTION_KEY' | ||
| ); | ||
|
|
||
| expect(toast).toMatchObject({ | ||
| type: 'danger', | ||
| message: 'Bulk action failed', | ||
| }); | ||
| expect(toast.link).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('falls back to a generic message when no usable message exists', () => { | ||
| const toast = bulkErrorToastParams({}, 'BULK_ACTION_KEY'); | ||
|
|
||
| expect(toast).toMatchObject({ | ||
| type: 'danger', | ||
| message: 'Unexpected error occurred.', | ||
| }); | ||
| expect(toast.link).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('keeps failed hosts link when response error has no message', () => { | ||
| const toast = bulkErrorToastParams( | ||
| { | ||
| response: { | ||
| data: { | ||
| error: { | ||
| failed_host_ids: [1, 2], | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| 'BULK_ACTION_KEY' | ||
| ); | ||
|
|
||
| expect(toast).toMatchObject({ | ||
| type: 'danger', | ||
| message: 'Unexpected error occurred.', | ||
| }); | ||
| expect(toast.link.children).toBe('Failed hosts'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('buildBulkRequestBody', () => { | ||
| it('builds an included search from fetchBulkParams', () => { | ||
| const body = buildBulkRequestBody({ | ||
| fetchBulkParams: () => 'id ^ (1,2,3)', | ||
| reboot: true, | ||
| }); | ||
|
|
||
| expect(body).toEqual({ | ||
| included: { | ||
| search: 'id ^ (1,2,3)', | ||
| }, | ||
| reboot: true, | ||
| }); | ||
| }); | ||
|
|
||
| it('adds taxonomy params when present', () => { | ||
| const body = buildBulkRequestBody({ | ||
| fetchBulkParams: () => 'id ^ (1,2,3)', | ||
| organizationId: 1, | ||
| locationId: 2, | ||
| }); | ||
|
|
||
| expect(body).toMatchObject({ | ||
| included: { | ||
| search: 'id ^ (1,2,3)', | ||
| }, | ||
| organization_id: 1, | ||
| location_id: 2, | ||
| }); | ||
| }); | ||
|
|
||
| it('uses includedSearch instead of calling fetchBulkParams', () => { | ||
| const fetchBulkParams = jest.fn(); | ||
|
|
||
| const body = buildBulkRequestBody({ | ||
| fetchBulkParams, | ||
| includedSearch: 'name ~ test', | ||
| }); | ||
|
|
||
| expect(body).toEqual({ | ||
| included: { | ||
| search: 'name ~ test', | ||
| }, | ||
| }); | ||
| expect(fetchBulkParams).not.toHaveBeenCalled(); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.