Fixes #39463 - show error toasts correct

[sbernhard]

No description provided.

[chris1984]

Looks fine to me, I asked Claude to look and it's saying it's present in two other areas, did you want to fix them in this pr as well?

• BulkBuildHostModal.js:42 — { ...response.data.error, key: HOST_BUILD_KEY } will crash identically when response is undefined (e.g. network error). It destructures { response } but doesn't guard it.
  • BulkReassignHostgroupModal.js:130 — ...response.data.error with the old response parameter signature (not destructured from the error object at all), so it'll crash on both network errors and any error shape where the callback receives { response, message }.

[sbernhard]

@chris1984 Thanks. Yes, this make sense.
Added these cases and even more; restructured the PR; added tests ... but not yet tested.

[chris1984]

LGTM, thanks for fixing the other things I suggested. Will let @jeremylenz have a final look to make sure I didn't miss anything

[jeremylenz]

LGTM, @sbernhard please mark as ready for review if this is ready to merge.

[Lukshio]

Little bit late to the party. But could you please provide more information about the issue? If I understand it correctly. Due to some parsing issues or foreman limitations (max len. 60 chars.) you are using custom addToast instead of APIActions build in successToast and errorToast.

And this new code should unify the parsing for all of the places?

We opened issue which should solve the parsing problems directly in APIActions unfortunately we are not there yet :/
https://projects.theforeman.org/issues/39296

[Lukshio]

I've just made a quick look at the code and found some things to clarify.
Also could you please update the PR title to be more accurate with what is changing?