Skip to content

Implement LDAP CA certs support #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adamlazik1 wants to merge 2 commits into
base: develop
Choose a base branch
from
+22 −0
Draft

Implement LDAP CA certs support #1985

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47be01f
Implement LDAP CA certs support
adamlazik1 Jul 17, 2026
c358fc0
Clarify cacert param description
adamlazik1 Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions plugins/modules/auth_source_ldap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@
description: Whether or not to use TLS when contacting the LDAP server.
required: false
type: bool
cacert:
description:
- PEM-encoded CA certificate(s) used to verify the LDAP server when LDAPS is enabled.
- Leave empty to use the system trust store.

@adamruzicka adamruzicka Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sort of reads like it is either-or, while the foreman-side code seems to be additive.

@adamlazik1 adamlazik1 Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean, system trust store is used even when adidtional cacerts are provided via param?

@adamruzicka adamruzicka Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and that's fine, but we should be clear about it

@adamlazik1 adamlazik1 Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

required: false
type: str
groups_base:
description: Base DN where groups reside.
required: false
Expand Down Expand Up @@ -181,6 +187,19 @@
username: "admin"
password: "changeme"
state: present

- name: LDAPS with a custom CA certificate
theforeman.foreman.auth_source_ldap:
name: "Example LDAPS"
host: "ldap.example.org"
port: 636
tls: true
cacert: "{{ lookup('file', '/path/to/ldap-ca.pem') }}"
server_type: free_ipa
server_url: "https://foreman.example.com"
username: "admin"
password: "changeme"
state: present
'''

RETURN = '''
Expand Down Expand Up @@ -220,6 +239,7 @@ def main():
onthefly_register=dict(type='bool'),
usergroup_sync=dict(type='bool'),
tls=dict(type='bool'),
cacert=dict(),
groups_base=dict(),
server_type=dict(choices=["free_ipa", "active_directory", "posix"]),
ldap_filter=dict(),
Expand Down
1 change: 1 addition & 0 deletions roles/auth_sources_ldap/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
onthefly_register: "{{ item.onthefly_register | default(omit) }}"
usergroup_sync: "{{ item.usergroup_sync | default(omit) }}"
tls: "{{ item.tls | default(omit) }}"
cacert: "{{ item.cacert | default(omit) }}"
groups_base: "{{ item.groups_base | default(omit) }}"
host: "{{ item.host | default(omit) }}"
port: "{{ item.port | default(omit) }}"
Expand Down
1 change: 1 addition & 0 deletions tests/test_playbooks/tasks/auth_source_ldap.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
onthefly_register: "{{ auth_source_ldap_onthefly_register }}"
usergroup_sync: "{{ auth_source_ldap_usergroup_sync }}"
tls: "{{ auth_source_ldap_tls }}"
cacert: "{{ auth_source_ldap_cacert | default(omit) }}"
groups_base: "{{ auth_source_ldap_groups_base }}"
server_type: "{{ auth_source_ldap_server_type }}"
ldap_filter: "{{ auth_source_ldap_ldap_filter }}"
Expand Down