Implement LDAP CA certs support#1985
Draft
adamlazik1 wants to merge 2 commits into
Draft
Conversation
Made with Cursor.
adamruzicka
reviewed
Jul 20, 2026
Comment on lines
+102
to
+103
| - PEM-encoded CA certificate(s) used to verify the LDAP server when LDAPS is enabled. | ||
| - Leave empty to use the system trust store. |
Contributor
There was a problem hiding this comment.
This sort of reads like it is either-or, while the foreman-side code seems to be additive.
Contributor
Author
There was a problem hiding this comment.
You mean, system trust store is used even when adidtional cacerts are provided via param?
Contributor
There was a problem hiding this comment.
Yes and that's fine, but we should be clear about it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made with Cursor.
Requires theforeman/foreman#11107