use ForemanApi from apypie#1789
Merged
Merged
Conversation
evgeni
force-pushed
the
the-refactoring
branch
9 times, most recently
from
October 28, 2024 11:49
4e78098 to
9a2b637
Compare
evgeni
force-pushed
the
the-refactoring
branch
2 times, most recently
from
October 28, 2024 12:44
3dd17c4 to
ef6595f
Compare
ekohl
reviewed
Oct 28, 2024
ekohl
left a comment
ekohl
left a comment
Member
There was a problem hiding this comment.
Consider this some of the notes I made while reading this. I realize it's very much a work in progress and should result in a real PR to apypie itself before updating the vendored copy.
evgeni
force-pushed
the
the-refactoring
branch
4 times, most recently
from
October 30, 2024 09:27
8121f36 to
9adb24b
Compare
evgeni
force-pushed
the
the-refactoring
branch
4 times, most recently
from
November 21, 2024 09:19
6dee41e to
94c0813
Compare
evgeni
changed the title
evgeni
force-pushed
the
the-refactoring
branch
from
November 22, 2024 08:24
94c0813 to
2a2027b
Compare
evgeni
marked this pull request as ready for review
November 22, 2024 08:25
ekohl
approved these changes
Nov 22, 2024
evgeni
force-pushed
the
the-refactoring
branch
from
November 26, 2024 07:20
2a2027b to
560f9a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
includes #1797