use the api to create a set of reusable fixtures by evgeni · Pull Request #43 · theforeman/foremanctl

evgeni · 2024-10-25T12:05:59Z

No description provided.

ekohl · 2024-11-05T17:59:22Z

+def yum_repository(product, organization, foremanapi):
+    repo = foremanapi.create('repositories', {'name': str(uuid.uuid4()), 'product_id': product['id'], 'content_type': 'yum', 'url': 'https://fixtures.pulpproject.org/rpm-no-comps/'})


I don't know how far you want to take this, but I think you can even make the URL a parameter so it can be overridden

Suggested change

def yum_repository(product, organization, foremanapi):

repo = foremanapi.create('repositories', {'name': str(uuid.uuid4()), 'product_id': product['id'], 'content_type': 'yum', 'url': 'https://fixtures.pulpproject.org/rpm-no-comps/'})

def yum_repository(product, organization, foremanapi, url='https://fixtures.pulpproject.org/rpm-no-comps/'):

repo = foremanapi.create('repositories', {'name': str(uuid.uuid4()), 'product_id': product['id'], 'content_type': 'yum', 'url': url})

I don't think fixtures take regular parameters like this (there are fixture factories, but those are more complicated)

https://docs.pytest.org/en/7.1.x/example/parametrize.html#indirect-parametrization says you can do it, but you need to use request.param. Feel free to leave it out for now, but let's keep it in mind for the future.

Oh via indirect… Mhh, interesting. Maybe. I'll think about it.

#60 is to track this, merging as is for now

ekohl · 2024-11-05T18:04:09Z

+def lifecycle_environment(organization, foremanapi):
+    library = foremanapi.list('lifecycle_environments', 'name=Library', {'organization_id': organization['id']})[0]


Same here perhaps?

Suggested change

def lifecycle_environment(organization, foremanapi):

library = foremanapi.list('lifecycle_environments', 'name=Library', {'organization_id': organization['id']})[0]

def lifecycle_environment(organization, foremanapi, prior='Library'):

library = foremanapi.list('lifecycle_environments', f'name={prior}', {'organization_id': organization['id']})[0]

Though perhaps it should just accept an instance where None is automatically resolve to the library:

Suggested change

def lifecycle_environment(organization, foremanapi):

library = foremanapi.list('lifecycle_environments', 'name=Library', {'organization_id': organization['id']})[0]

def lifecycle_environment(organization, foremanapi, prior=None):

if not prior:

prior = foremanapi.list('lifecycle_environments', 'name=Library', {'organization_id': organization['id']})[0]

Which also makes me question what the Katello API does if no prior ID is given. It's not listed as required and mandating this, but would it make sense to find the library server side and make it an optional parameter?

It does not find "Library" automatically and errors out:
https://github.com/Katello/katello/blob/db89c59031e34994805faaf3c6314b0e412b56c3/app/controllers/katello/api/v2/environments_controller.rb#L39
https://github.com/Katello/katello/blob/db89c59031e34994805faaf3c6314b0e412b56c3/app/controllers/katello/api/v2/environments_controller.rb#L172-L177

I meant that last part as an RFE.

evgeni · 2024-11-07T09:12:54Z

+    )
+
+@pytest.fixture
+def organization(foremanapi):


Right now all these tests have an (implicit) scope=function (https://docs.pytest.org/en/stable/how-to/fixtures.html#fixture-scopes) which means that they are destroyed at the end of every test.

Conceptually, this is good, of course. But on the flip side this means that every repository test also first creates a new org (also in Candlepin), a new product, etc. Those times quickly add up, and make the test tiresome to execute.

We can speed this up with scope=module, but this means that any failure in a test might have cascading effects on later tests (which is the same behaviour as we have today with bats, FWIW).

WDYT?

For now I'd lean to the isolation given we still have very few tests, but I agree in the future it will add up. Later we can add a "persistent" fixture that can be reused.

Given we have isolation, it's probably also easy to run things in parallel. Those failures may be harder to diagnose, but it can also uncover real work concurrency issues which large deployments will see at some point.

ekohl · 2024-11-12T19:38:58Z

+          vagrant up quadlet
+          vagrant up client


Do you intentionally start them up sequentially instead of parallel? Is that the issue with fetching the same box concurrently giving issues?

I honestly haven't tried 😅

ehelms · 2024-11-18T19:25:45Z

Generally looks good.. what's needed to get it out of draft?

evgeni · 2024-11-19T08:42:06Z

Generally looks good.. what's needed to get it out of draft?

add ForemanApi Apipie/apypie#175 being merged and released
cleanup of the git history here

ehelms · 2024-11-20T14:15:56Z

  hosts: all
  become: true
+  roles:
+    - theforeman.forklift.etc_hosts


evgeni marked this pull request as draft October 25, 2024 12:06

evgeni commented Oct 25, 2024

View reviewed changes

Comment thread tests/conftest.py Outdated

evgeni commented Oct 25, 2024

View reviewed changes

Comment thread tests/conftest.py Outdated

evgeni commented Oct 25, 2024

View reviewed changes

Comment thread tests/conftest.py Outdated

evgeni force-pushed the apifixtures branch 8 times, most recently from bae103c to 510ad5b Compare October 28, 2024 08:52

evgeni mentioned this pull request Oct 29, 2024

Fixes #30368 - Make Candlepin CA file optional Katello/katello#8832

Merged

evgeni force-pushed the apifixtures branch from cf94e0c to 5290bb1 Compare October 29, 2024 07:16

evgeni commented Oct 29, 2024

View reviewed changes

Comment thread tests/foreman_api_test.py Outdated

evgeni force-pushed the apifixtures branch from 7ea380c to aa10cb6 Compare October 29, 2024 09:33

evgeni commented Oct 29, 2024

View reviewed changes

Comment thread requirements.txt Outdated

ekohl reviewed Oct 30, 2024

View reviewed changes

Comment thread tests/foreman_api_test.py

evgeni force-pushed the apifixtures branch from 6036a69 to 1430207 Compare October 30, 2024 12:54

evgeni commented Oct 30, 2024

View reviewed changes

Comment thread tests/zzz_test.py Outdated

evgeni force-pushed the apifixtures branch from 1430207 to 8ae881e Compare October 30, 2024 16:24

evgeni commented Nov 4, 2024

View reviewed changes

Comment thread Vagrantfile Outdated

evgeni force-pushed the apifixtures branch from 8ae881e to 9d49f32 Compare November 4, 2024 11:19

evgeni mentioned this pull request Nov 5, 2024

add pulp services #34

Merged

evgeni force-pushed the apifixtures branch from 973fde9 to 9bcf70d Compare November 5, 2024 17:37

ekohl reviewed Nov 5, 2024

View reviewed changes

evgeni commented Nov 7, 2024

View reviewed changes

ekohl reviewed Nov 12, 2024

View reviewed changes

Comment thread run_tests Outdated

evgeni commented Nov 13, 2024

View reviewed changes

Comment thread tests/conftest.py

evgeni force-pushed the apifixtures branch 4 times, most recently from 31c26f3 to d926760 Compare November 18, 2024 14:04

evgeni force-pushed the apifixtures branch from d926760 to f241ccd Compare November 19, 2024 09:22

evgeni added 3 commits November 19, 2024 12:51

use the api to create a set of reusable fixtures

3bd45fd

add client test machine

2df791c

add client based testing

2527c57

evgeni force-pushed the apifixtures branch from f241ccd to d9c6a35 Compare November 19, 2024 11:51

evgeni marked this pull request as ready for review November 19, 2024 11:52

ehelms reviewed Nov 19, 2024

View reviewed changes

Comment thread ansible.cfg Outdated

evgeni force-pushed the apifixtures branch from 89004fb to 6fbfd17 Compare November 20, 2024 13:12

evgeni commented Nov 20, 2024

View reviewed changes

Comment thread requirements.yml Outdated

setup "dns" using forklift's etc_hosts role

0a8f261

evgeni force-pushed the apifixtures branch from 6fbfd17 to 0a8f261 Compare November 20, 2024 14:10

ehelms reviewed Nov 20, 2024

View reviewed changes

Comment thread playbooks/setup.yaml

hosts: all

become: true

roles:

- theforeman.forklift.etc_hosts

ehelms Nov 20, 2024

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

ehelms approved these changes Nov 20, 2024

View reviewed changes

evgeni mentioned this pull request Nov 20, 2024

create more flexible fixtures #60

Open

evgeni merged commit 177348f into theforeman:master Nov 20, 2024

evgeni deleted the apifixtures branch November 20, 2024 14:52

evgeni mentioned this pull request Nov 20, 2024

Pulp tests #53

Closed

		def yum_repository(product, organization, foremanapi):
		repo = foremanapi.create('repositories', {'name': str(uuid.uuid4()), 'product_id': product['id'], 'content_type': 'yum', 'url': 'https://fixtures.pulpproject.org/rpm-no-comps/'})

		def lifecycle_environment(organization, foremanapi):
		library = foremanapi.list('lifecycle_environments', 'name=Library', {'organization_id': organization['id']})[0]

-def lifecycle_environment(organization, foremanapi):
-    library = foremanapi.list('lifecycle_environments', 'name=Library', {'organization_id': organization['id']})[0]
+def lifecycle_environment(organization, foremanapi, prior=None):
+    if not prior:
+        prior = foremanapi.list('lifecycle_environments', 'name=Library', {'organization_id': organization['id']})[0]

Uh oh!

Conversation

evgeni commented Oct 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ehelms commented Nov 18, 2024

Uh oh!

evgeni commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

evgeni commented Nov 19, 2024 •

edited

Loading