Repository navigation
test(core): adapter import rules and lint fixtures - #7
Merged
Merged
Conversation
|
| Topic | Details | ||||||
|---|---|---|---|---|---|---|---|
| Adapter boundaries | Expand adapter-imports.test.ts to validate adapter isolation, app and provider restrictions, server composition exceptions, dynamic imports, relative paths, indirect loaders, and clean real-tree linting across available roots.Modified files (7)
Latest Contributors(1)
| ||||||
| Lint fixtures | Verify core lint fixtures report exactly one expected ESLint boundary violation, cover static/subpath/dynamic imports and environment access, and preserve allowed or clean cases.Modified files (1)
Latest Contributors(1)
|
omercnet
force-pushed
the
replay/03-scan
branch
from
November 21, 2026 10:06
77e3e03 to
fd85c87
Compare
omercnet
force-pushed
the
replay/04-lintfx
branch
from
November 21, 2026 10:06
f28f3b1 to
99d4499
Compare
omercnet
force-pushed
the
replay/03-scan
branch
from
November 21, 2026 10:11
fd85c87 to
df55b65
Compare
omercnet
force-pushed
the
replay/04-lintfx
branch
2 times, most recently
from
November 21, 2026 10:14
c7a5339 to
6a6e109
Compare
omercnet
force-pushed
the
replay/03-scan
branch
from
November 21, 2026 10:17
e0f1608 to
cca496c
Compare
omercnet
force-pushed
the
replay/04-lintfx
branch
from
November 21, 2026 10:17
6a6e109 to
2e1dc15
Compare
3 tasks done
omercnet
force-pushed
the
replay/04-lintfx
branch
from
November 21, 2026 10:19
2e1dc15 to
97dd3d1
Compare
omercnet
marked this pull request as ready for review
November 21, 2026 10:31
omercnet
force-pushed
the
replay/04-lintfx
branch
from
November 21, 2026 10:31
97dd3d1 to
e26c514
Compare
omercnet
enabled auto-merge (squash)
November 21, 2026 10:31
🐕 Shuni ReviewNo new issues found. 🤖 Model: Review scope: Partial incremental re-review Reviewed new changes (1)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The adapter import rules test (
adapter-imports.test.ts: adapter to adapter, adapter to apps, provider SDK imports) and the lint-fixture test that runs ESLint over the fixture files and expects exactly the named rule to fire. 8 files (the other 17 fixtures arrived in the scanner slice).Stacked on #6 (which is stacked on #4). Auto-merge stays off until the base has merged and this branch has been rebased onto
mainand retargeted.Why
Keeps the layering rules (core, adapters, apps) enforced by tests from the start.
How it was verified
npm ci --ignore-scripts, lint, typecheck, build,npm test(145 tests),npm run test:tools, gitleaks (git and dir), actionlint, zizmor: all exit 0. The diff against its base is exactly the 8 files of this slice.The "real tree lints clean" test lints
appsandpackages;appsdoes not exist yet, so it now lints only the roots that exist (3 lines, mirrored in the private project).Not here yet
More ports and the licence check (next slices).
Checklist