Repository navigation
feat(core): database, markdown, user, auth and access ports with in-memory fakes - #9
Merged
Merged
Conversation
|
| Topic | Details | ||||||
|---|---|---|---|---|---|---|---|
| Core service ports | Define the interfaces that core flows use for persistence, authentication, user lifecycle, Markdown conversion, development roles, and access fact retrieval.Modified files (6)
Latest Contributors(1)
| ||||||
| Fakes and contracts | Provide deterministic in-memory implementations and shared contract tests to validate database, Markdown, authentication, user, and access port behavior before adapters arrive.Modified files (8)
Latest Contributors(1)
|
omercnet
force-pushed
the
replay/04-lintfx
branch
from
November 21, 2026 10:19
2e1dc15 to
97dd3d1
Compare
omercnet
force-pushed
the
replay/05-ports
branch
from
November 21, 2026 10:19
d97e653 to
6819876
Compare
omercnet
force-pushed
the
replay/04-lintfx
branch
from
November 21, 2026 10:31
97dd3d1 to
e26c514
Compare
omercnet
force-pushed
the
replay/05-ports
branch
from
November 21, 2026 10:37
6819876 to
47edb2e
Compare
omercnet
marked this pull request as ready for review
November 21, 2026 10:40
omercnet
force-pushed
the
replay/05-ports
branch
from
November 21, 2026 10:40
47edb2e to
89eea8c
Compare
omercnet
enabled auto-merge (squash)
November 21, 2026 10:40
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The ports for the database, Markdown converter, user store, auth verifier and access store, with in-memory fakes, a shared database conformance suite, and contract tests for each port. 14 files.
Rebased onto
main(the slices below it have merged); auto-merge is on.Why
Core code depends only on these interfaces; the adapters that implement them come in later slices and must pass the same contract tests.
How it was verified
npm ci --ignore-scripts, lint, typecheck, build,npm test(159 tests),npm run test:tools, gitleaks (git and dir), actionlint, zizmor: all exit 0. The diff against its base is exactly the 14 files of this slice.Visuals
Not applicable: library interfaces and tests, nothing to show.
Not here yet
The access decision and authoriser (next slice), and every adapter.
Checklist